diff options
| author | Mark McLoughlin <markmc@redhat.com> | 2013-01-08 08:13:12 +0000 |
|---|---|---|
| committer | Mark McLoughlin <markmc@redhat.com> | 2013-01-09 08:15:43 +0000 |
| commit | 39a46f48bfcaae1ca4500ba145c1c08c6bf009f1 (patch) | |
| tree | e6c6ea5637c8d1d2fc90b93cdce345ad71a0d6f2 /nova/api | |
| parent | 41ef13a34c4fa41052ae72cc87e552dfd8ed91ba (diff) | |
| download | nova-39a46f48bfcaae1ca4500ba145c1c08c6bf009f1.tar.gz nova-39a46f48bfcaae1ca4500ba145c1c08c6bf009f1.tar.xz nova-39a46f48bfcaae1ca4500ba145c1c08c6bf009f1.zip | |
Move vpn_image_id to pipelib
Apart from checking whether a given image is the cloudpipe image, the
vpn_image_id option is only used within pipelib itself.
Add a is_vpn_image() helper method and move the option into pipelib.
Some rejiggering of how pipelib imports ec2 opts is required to avoid
circular imports.
blueprint: scope-config-opts
Change-Id: Ie984b2bb81681c24d3cee803082960083992a535
Diffstat (limited to 'nova/api')
| -rw-r--r-- | nova/api/ec2/cloud.py | 4 | ||||
| -rw-r--r-- | nova/api/openstack/compute/contrib/cloudpipe.py | 3 |
2 files changed, 3 insertions, 4 deletions
diff --git a/nova/api/ec2/cloud.py b/nova/api/ec2/cloud.py index 66ef7fe37..db8104dbc 100644 --- a/nova/api/ec2/cloud.py +++ b/nova/api/ec2/cloud.py @@ -30,6 +30,7 @@ from nova.api.ec2 import inst_state from nova.api import validator from nova import availability_zones from nova import block_device +from nova.cloudpipe import pipelib from nova import compute from nova.compute import api as compute_api from nova.compute import instance_types @@ -71,7 +72,6 @@ ec2_opts = [ CONF = cfg.CONF CONF.register_opts(ec2_opts) CONF.import_opt('my_ip', 'nova.config') -CONF.import_opt('vpn_image_id', 'nova.config') CONF.import_opt('vpn_key_suffix', 'nova.config') CONF.import_opt('internal_service_availability_zone', 'nova.availability_zones') @@ -1132,7 +1132,7 @@ class CloudController(object): for instance in instances: if not context.is_admin: - if instance['image_ref'] == str(CONF.vpn_image_id): + if pipelib.is_vpn_image(instance['image_ref']): continue i = {} instance_uuid = instance['uuid'] diff --git a/nova/api/openstack/compute/contrib/cloudpipe.py b/nova/api/openstack/compute/contrib/cloudpipe.py index bb3007735..c4fe8f52a 100644 --- a/nova/api/openstack/compute/contrib/cloudpipe.py +++ b/nova/api/openstack/compute/contrib/cloudpipe.py @@ -31,7 +31,6 @@ from nova.openstack.common import timeutils from nova import utils CONF = cfg.CONF -CONF.import_opt('vpn_image_id', 'nova.config') LOG = logging.getLogger(__name__) authorize = extensions.extension_authorizer('compute', 'cloudpipe') @@ -77,7 +76,7 @@ class CloudpipeController(object): instances = self.compute_api.get_all(context, search_opts={'deleted': False}) return [instance for instance in instances - if instance['image_ref'] == str(CONF.vpn_image_id) + if pipelib.is_vpn_image(instance['image_ref']) and instance['vm_state'] != vm_states.DELETED] def _get_cloudpipe_for_project(self, context, project_id): |