diff options
| author | Aaron Rosen <arosen@nicira.com> | 2013-05-21 21:18:29 -0700 |
|---|---|---|
| committer | Aaron Rosen <arosen@nicira.com> | 2013-05-21 22:24:35 -0700 |
| commit | 0604e77654d0c7eb5fda9600e9ca604da656d856 (patch) | |
| tree | c6f2099bd3b50b333b7674bec1454d634d1d34f8 /nova/api | |
| parent | 5d40fb635b1abac3828245124e392a4c9af52f60 (diff) | |
| download | nova-0604e77654d0c7eb5fda9600e9ca604da656d856.tar.gz nova-0604e77654d0c7eb5fda9600e9ca604da656d856.tar.xz nova-0604e77654d0c7eb5fda9600e9ca604da656d856.zip | |
Optimize SecurityGroupsOutputController by len(servers)
The following patch adds an optimization for _extend_servers() so that
it calls get_instance_security_groups() when len(servers) == 1, and
get_instances_security_groups_bindings() when > 1. In addition, this patch
adds a return statement if not len(servers) as there is no reason to
perform a query if there are no servers.
Fixes bug 1182730
Change-Id: I149bf32176d60e72d76576168d15995f7215b657
Diffstat (limited to 'nova/api')
| -rw-r--r-- | nova/api/openstack/compute/contrib/security_groups.py | 23 |
1 files changed, 16 insertions, 7 deletions
diff --git a/nova/api/openstack/compute/contrib/security_groups.py b/nova/api/openstack/compute/contrib/security_groups.py index de5a9bd8e..87ef6d882 100644 --- a/nova/api/openstack/compute/contrib/security_groups.py +++ b/nova/api/openstack/compute/contrib/security_groups.py @@ -466,6 +466,8 @@ class SecurityGroupsOutputController(wsgi.Controller): def _extend_servers(self, req, servers): # TODO(arosen) this function should be refactored to reduce duplicate # code and use get_instance_security_groups instead of get_db_instance. + if not len(servers): + return key = "security_groups" context = _authorize_context(req) if not openstack_driver.is_quantum_security_groups(): @@ -480,13 +482,20 @@ class SecurityGroupsOutputController(wsgi.Controller): # quantum security groups the requested security groups for the # instance are not in the db and have not been sent to quantum yet. if req.method != 'POST': - sg_instance_bindings = ( - self.security_group_api - .get_instances_security_groups_bindings(context)) - for server in servers: - groups = sg_instance_bindings.get(server['id']) - if groups: - server[key] = groups + if len(servers) == 1: + group = (self.security_group_api + .get_instance_security_groups(context, + servers[0]['id'])) + if group: + servers[0][key] = group + else: + sg_instance_bindings = ( + self.security_group_api + .get_instances_security_groups_bindings(context)) + for server in servers: + groups = sg_instance_bindings.get(server['id']) + if groups: + server[key] = groups # In this section of code len(servers) == 1 as you can only POST # one server in an API request. else: |