summaryrefslogtreecommitdiffstats
path: root/bin
diff options
context:
space:
mode:
authorSean Dague <sdague@linux.vnet.ibm.com>2013-01-09 16:00:36 -0500
committerSean Dague <sdague@linux.vnet.ibm.com>2013-01-10 08:57:09 -0500
commit5fca1d9e97913af549adaef0827b189540fc87fa (patch)
tree2a090d66f2288a0972eec2a1c65e4cc2ddeaee1b /bin
parent8143021bdb5ec10ea60a6613e29bdc9347701a04 (diff)
downloadnova-5fca1d9e97913af549adaef0827b189540fc87fa.tar.gz
nova-5fca1d9e97913af549adaef0827b189540fc87fa.tar.xz
nova-5fca1d9e97913af549adaef0827b189540fc87fa.zip
fix new N402 errors
fix the N402 errors that have slipped in in the last 48 hrs since starting this patch series. fix an N401 error that our scanner current can't find because it only looks for doc strings on classes and defs. this is the xeno's paradox of patch series, but we're getting close. Change-Id: I4a763bb4c812335d853eae05c72464f18ab93297
Diffstat (limited to 'bin')
-rwxr-xr-xbin/nova-baremetal-deploy-helper20
1 files changed, 10 insertions, 10 deletions
diff --git a/bin/nova-baremetal-deploy-helper b/bin/nova-baremetal-deploy-helper
index fa0a30d9e..f8a487d37 100755
--- a/bin/nova-baremetal-deploy-helper
+++ b/bin/nova-baremetal-deploy-helper
@@ -56,7 +56,7 @@ QUEUE = Queue.Queue()
# They are split for stub-out.
def discovery(portal_address, portal_port):
- """Do iSCSI discovery on portal"""
+ """Do iSCSI discovery on portal."""
utils.execute('iscsiadm',
'-m', 'discovery',
'-t', 'st',
@@ -66,7 +66,7 @@ def discovery(portal_address, portal_port):
def login_iscsi(portal_address, portal_port, target_iqn):
- """Login to an iSCSI target"""
+ """Login to an iSCSI target."""
utils.execute('iscsiadm',
'-m', 'node',
'-p', '%s:%s' % (portal_address, portal_port),
@@ -79,7 +79,7 @@ def login_iscsi(portal_address, portal_port, target_iqn):
def logout_iscsi(portal_address, portal_port, target_iqn):
- """Logout from an iSCSI target"""
+ """Logout from an iSCSI target."""
utils.execute('iscsiadm',
'-m', 'node',
'-p', '%s:%s' % (portal_address, portal_port),
@@ -90,7 +90,7 @@ def logout_iscsi(portal_address, portal_port, target_iqn):
def make_partitions(dev, root_mb, swap_mb):
- """Create partitions for root and swap on a disk device"""
+ """Create partitions for root and swap on a disk device."""
commands = ['o,w',
'n,p,1,,+%dM,t,1,83,w' % root_mb,
'n,p,2,,+%dM,t,2,82,w' % swap_mb,
@@ -106,13 +106,13 @@ def make_partitions(dev, root_mb, swap_mb):
def is_block_device(dev):
- """Check whether a device is block or not"""
+ """Check whether a device is block or not."""
s = os.stat(dev)
return stat.S_ISBLK(s.st_mode)
def dd(src, dst):
- """Execute dd from src to dst"""
+ """Execute dd from src to dst."""
utils.execute('dd',
'if=%s' % src,
'of=%s' % dst,
@@ -122,7 +122,7 @@ def dd(src, dst):
def mkswap(dev, label='swap1'):
- """Execute mkswap on a device"""
+ """Execute mkswap on a device."""
utils.execute('mkswap',
'-L', label,
dev,
@@ -131,7 +131,7 @@ def mkswap(dev, label='swap1'):
def block_uuid(dev):
- """Get UUID of a block device"""
+ """Get UUID of a block device."""
out, _ = utils.execute('blkid', '-s', 'UUID', '-o', 'value', dev,
run_as_root=True,
check_exit_code=[0])
@@ -219,7 +219,7 @@ def deploy(address, port, iqn, lun, image_path, pxe_config_path,
class Worker(threading.Thread):
- """Thread that handles requests in queue"""
+ """Thread that handles requests in queue."""
def __init__(self):
super(Worker, self).__init__()
@@ -250,7 +250,7 @@ class Worker(threading.Thread):
class BareMetalDeploy(object):
- """WSGI server for bare-metal deployment"""
+ """WSGI server for bare-metal deployment."""
def __init__(self):
self.worker = Worker()