summaryrefslogtreecommitdiffstats
path: root/bin/stack
diff options
context:
space:
mode:
authorScott Moser <smoser@ubuntu.com>2011-09-20 05:40:18 -0400
committerScott Moser <smoser@ubuntu.com>2011-09-20 05:40:18 -0400
commit382f1dc728c2503e28237e9b2b455d46570943e6 (patch)
treecd5baf965be93578406e69d15ab6b0c034f294a5 /bin/stack
parent2eb2120f98cfe70ce67325ffe26cfb5cc86c6356 (diff)
downloadnova-382f1dc728c2503e28237e9b2b455d46570943e6.tar.gz
nova-382f1dc728c2503e28237e9b2b455d46570943e6.tar.xz
nova-382f1dc728c2503e28237e9b2b455d46570943e6.zip
Address Soren's comments:
* clean up temp files if an ImageUnacceptable is going to be raised Note, a qemu-img execution error will not clean up the image, but I think thats reasonable. We leave the image on disk so the user can easily investigate. * Change final 2 arguments to fetch_to_raw to not start with an _ * use 'env' utility to change environment variables LC_ALL and LANG so that qemu-img output parsing is not locale dependent. Note, I considered the following, but found using 'env' more readable out, err = utils.execute('sh', '-c', 'export LC_ALL=C LANG=C && exec "$@"', 'qemu-img', 'info', path)
Diffstat (limited to 'bin/stack')
0 files changed, 0 insertions, 0 deletions