Some code was recently added to glance to allow the is_public filter to be overridden. This allows us to get all images and filter properly on the nova side until keystone support is in glance. This fixes the issue with private images and snapshots disappearing from the image list.

3 files changed, 36 insertions, 7 deletions

diff --git a/nova/image/glance.py b/nova/image/glance.py
index 55d948a32..5c2dc957b 100644
--- a/nova/image/glance.py
+++ b/nova/image/glance.py
@@ -89,6 +89,10 @@ class GlanceImageService(service.BaseImageService):
         # `get_images` here because we need `is_public` and `properties`
         # included so we can filter by user
         filtered = []
+        filters = filters or {}
+        if 'is_public' not in filters:
+            # NOTE(vish): don't filter out private images
+            filters['is_public'] = 'none'
         image_metas = self.client.get_images_detailed(filters=filters,
                                                       marker=marker,
                                                       limit=limit)
@@ -101,6 +105,10 @@ class GlanceImageService(service.BaseImageService):
     def detail(self, context, filters=None, marker=None, limit=None):
         """Calls out to Glance for a list of detailed image information."""
         filtered = []
+        filters = filters or {}
+        if 'is_public' not in filters:
+            # NOTE(vish): don't filter out private images
+            filters['is_public'] = 'none'
         image_metas = self.client.get_images_detailed(filters=filters,
                                                       marker=marker,
                                                       limit=limit)
diff --git a/nova/image/s3.py b/nova/image/s3.py
index 4a3df98ba..c313c7a13 100644
--- a/nova/image/s3.py
+++ b/nova/image/s3.py
@@ -168,7 +168,7 @@ class S3ImageService(service.BaseImageService):
         metadata.update({'disk_format': image_format,
                          'container_format': image_format,
                          'status': 'queued',
-                         'is_public': True,
+                         'is_public': False,
                          'properties': properties})
         metadata['properties']['image_state'] = 'pending'
         image = self.service.create(context, metadata)
diff --git a/smoketests/test_sysadmin.py b/smoketests/test_sysadmin.py
index 268d9865b..454f6f1d5 100644
--- a/smoketests/test_sysadmin.py
+++ b/smoketests/test_sysadmin.py
@@ -103,27 +103,48 @@ class ImageTests(base.UserSmokeTestCase):
                                                'launchPermission')
         self.assert_(attrs.name, 'launch_permission')
 
-    def test_009_can_modify_image_launch_permission(self):
+    def test_009_can_add_image_launch_permission(self):
+        image = self.conn.get_image(self.data['image_id'])
+        self.assertEqual(image.id, self.data['image_id'])
+        self.assertEqual(image.is_public, False)
         self.conn.modify_image_attribute(image_id=self.data['image_id'],
                                          operation='add',
                                          attribute='launchPermission',
                                          groups='all')
         image = self.conn.get_image(self.data['image_id'])
         self.assertEqual(image.id, self.data['image_id'])
+        self.assertEqual(image.is_public, True)
 
     def test_010_can_see_launch_permission(self):
         attrs = self.conn.get_image_attribute(self.data['image_id'],
                                               'launchPermission')
-        self.assert_(attrs.name, 'launch_permission')
-        self.assert_(attrs.attrs['groups'][0], 'all')
+        self.assertEqual(attrs.name, 'launch_permission')
+        self.assertEqual(attrs.attrs['groups'][0], 'all')
+
+    def test_011_can_remove_image_launch_permission(self):
+        image = self.conn.get_image(self.data['image_id'])
+        self.assertEqual(image.id, self.data['image_id'])
+        self.assertEqual(image.is_public, True)
+        self.conn.modify_image_attribute(image_id=self.data['image_id'],
+                                         operation='remove',
+                                         attribute='launchPermission',
+                                         groups='all')
+        image = self.conn.get_image(self.data['image_id'])
+        self.assertEqual(image.id, self.data['image_id'])
+        self.assertEqual(image.is_public, False)
+
+    def test_012_private_image_shows_in_list(self):
+        images = self.conn.get_all_images()
+        image_ids = [image.id for image in images]
+        self.assertTrue(self.data['image_id'] in image_ids)
 
-    def test_011_user_can_deregister_kernel(self):
+    def test_013_user_can_deregister_kernel(self):
         self.assertTrue(self.conn.deregister_image(self.data['kernel_id']))
 
-    def test_012_can_deregister_image(self):
+    def test_014_can_deregister_image(self):
         self.assertTrue(self.conn.deregister_image(self.data['image_id']))
 
-    def test_013_can_delete_bundle(self):
+    def test_015_can_delete_bundle(self):
         self.assertTrue(self.delete_bundle_bucket(TEST_BUCKET))