diff options
| author | Nick Bartos <nick@pistoncloud.com> | 2012-02-19 19:15:12 -0800 |
|---|---|---|
| committer | Nick Bartos <nick@pistoncloud.com> | 2012-02-20 04:57:44 -0800 |
| commit | ea0e925972c944ac4586887d7fd2e9c27225dd83 (patch) | |
| tree | 84bdc6a707ef3e7c6e5663847f63a9ec3155aa97 | |
| parent | 9a174189b42fc59de9467f60eb6ca0ba4d80f6c8 (diff) | |
Escape apostrophe in utils.xhtml_escape() (lp#872450)
Also remove comment which is no longer relevant.
Change-Id: I33a951d08a34510b2a9dbacb9fb3ebf6bee978b4
| -rw-r--r-- | Authors | 1 | ||||
| -rw-r--r-- | nova/tests/test_utils.py | 4 | ||||
| -rw-r--r-- | nova/utils.py | 5 |
3 files changed, 6 insertions, 4 deletions
@@ -131,6 +131,7 @@ MotoKen <motokentsai@gmail.com> Muneyuki Noguchi <noguchimn@nttdata.co.jp> Nachi Ueno <ueno.nachi@lab.ntt.co.jp> Naveed Massjouni <naveedm9@gmail.com> +Nick Bartos <nick@pistoncloud.com> Nikhil Komawar <nikhil.komawar@rackspace.com> Nikolay Sokolov <nsokolov@griddynamics.com> Nirmal Ranganathan <rnirmal@gmail.com> diff --git a/nova/tests/test_utils.py b/nova/tests/test_utils.py index c60dc26a9..93146876e 100644 --- a/nova/tests/test_utils.py +++ b/nova/tests/test_utils.py @@ -696,6 +696,10 @@ class DeprecationTest(test.TestCase): result = utils.service_is_up(service) self.assertFalse(result) + def test_xhtml_escape(self): + self.assertEqual('"foo"', utils.xhtml_escape('"foo"')) + self.assertEqual(''foo'', utils.xhtml_escape("'foo'")) + def test_hash_file(self): data = 'Mary had a little lamb, its fleece as white as snow' flo = StringIO.StringIO(data) diff --git a/nova/utils.py b/nova/utils.py index 85f39dbe0..dc8a660a6 100644 --- a/nova/utils.py +++ b/nova/utils.py @@ -669,11 +669,8 @@ class LoopingCall(object): def xhtml_escape(value): """Escapes a string so it is valid within XML or XHTML. - Code is directly from the utf8 function in - http://github.com/facebook/tornado/blob/master/tornado/escape.py - """ - return saxutils.escape(value, {'"': '"'}) + return saxutils.escape(value, {'"': '"', "'": '''}) def utf8(value): |