summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSandy Walsh <sandy.walsh@rackspace.com>2011-02-17 16:18:03 -0400
committerSandy Walsh <sandy.walsh@rackspace.com>2011-02-17 16:18:03 -0400
commite77f8751dd59e5d650d047a6711c3d137947dda7 (patch)
tree7d09de669ac1b1eb312142582ffed4fc4dcc29c4
parentaa71a25c9f9bf5df3aea781138fa8d69654f06d9 (diff)
downloadnova-e77f8751dd59e5d650d047a6711c3d137947dda7.tar.gz
nova-e77f8751dd59e5d650d047a6711c3d137947dda7.tar.xz
nova-e77f8751dd59e5d650d047a6711c3d137947dda7.zip
fixup
-rwxr-xr-xbin/nova-combined4
-rw-r--r--nova/api/openstack/zones.py6
-rw-r--r--nova/flags.py2
-rw-r--r--nova/scheduler/manager.py2
-rw-r--r--nova/scheduler/zone_manager.py18
-rw-r--r--nova/tests/test_zones.py10
6 files changed, 21 insertions, 21 deletions
diff --git a/bin/nova-combined b/bin/nova-combined
index a0f552d64..913c866bf 100755
--- a/bin/nova-combined
+++ b/bin/nova-combined
@@ -53,11 +53,11 @@ if __name__ == '__main__':
compute = service.Service.create(binary='nova-compute')
network = service.Service.create(binary='nova-network')
- #volume = service.Service.create(binary='nova-volume')
+ volume = service.Service.create(binary='nova-volume')
scheduler = service.Service.create(binary='nova-scheduler')
#objectstore = service.Service.create(binary='nova-objectstore')
- service.serve(compute, network, scheduler)
+ service.serve(compute, network, volume, scheduler)
apps = []
paste_config_file = wsgi.paste_config_file('nova-api.conf')
diff --git a/nova/api/openstack/zones.py b/nova/api/openstack/zones.py
index bd2c488d9..f75176824 100644
--- a/nova/api/openstack/zones.py
+++ b/nova/api/openstack/zones.py
@@ -66,7 +66,7 @@ class Controller(wsgi.Controller):
def index(self, req):
"""Return all zones in brief"""
# Ask the ZoneManager in the Scheduler for most recent data.
- items = self._call_scheduler('get_zone_list',
+ items = self._call_scheduler('get_zone_list',
req.environ['nova.context'])
for item in items:
item['api_url'] = item['api_url'].replace('\\/', '/')
@@ -75,7 +75,7 @@ class Controller(wsgi.Controller):
if len(items) == 0:
items = db.zone_get_all(req.environ['nova.context'])
items = common.limited(items, req)
- items = [_exclude_keys(item, ['username', 'password'])
+ items = [_exclude_keys(item, ['username', 'password'])
for item in items]
return dict(zones=items)
@@ -85,7 +85,7 @@ class Controller(wsgi.Controller):
def info(self, req):
"""Return name and capabilities for this zone."""
- return dict(zone=dict(name=FLAGS.zone_name,
+ return dict(zone=dict(name=FLAGS.zone_name,
capabilities=FLAGS.zone_capabilities))
def show(self, req, id):
diff --git a/nova/flags.py b/nova/flags.py
index 0a45499f3..60d7cdd06 100644
--- a/nova/flags.py
+++ b/nova/flags.py
@@ -314,6 +314,6 @@ DEFINE_string('node_availability_zone', 'nova',
'availability zone of this node')
DEFINE_string('zone_name', 'nova', 'name of this zone')
-DEFINE_string('zone_capabilities', 'xen, linux',
+DEFINE_string('zone_capabilities', 'xen, linux',
'comma-delimited list of tags which represent boolean'
' capabilities of this zone')
diff --git a/nova/scheduler/manager.py b/nova/scheduler/manager.py
index 00a0f4100..7ced33b9c 100644
--- a/nova/scheduler/manager.py
+++ b/nova/scheduler/manager.py
@@ -36,7 +36,7 @@ FLAGS = flags.FLAGS
flags.DEFINE_string('scheduler_driver',
'nova.scheduler.chance.ChanceScheduler',
'Driver to use for the scheduler')
-
+
class SchedulerManager(manager.Manager):
"""Chooses a host to run instances on."""
diff --git a/nova/scheduler/zone_manager.py b/nova/scheduler/zone_manager.py
index 4fa528973..e7c37a9a6 100644
--- a/nova/scheduler/zone_manager.py
+++ b/nova/scheduler/zone_manager.py
@@ -47,14 +47,14 @@ class ZoneState(object):
self.last_seen = datetime.min
self.last_exception = None
self.last_exception_time = None
-
+
def update_credentials(self, zone):
"""Update zone credentials from db"""
self.zone_id = zone.id
self.api_url = zone.api_url
self.username = zone.username
self.password = zone.password
-
+
def update_metadata(self, zone_metadata):
"""Update zone metadata after successful communications with
child zone."""
@@ -79,10 +79,10 @@ class ZoneState(object):
self.attempt += 1
if self.attempt >= FLAGS.zone_failures_to_offline:
- self.is_active = False
- logging.error(_("No answer from zone %s after %d "
- "attempts. Marking inactive.") % (self.api_url,
- FLAGS.zone_failures_to_offline))
+ self.is_active = False
+ logging.error(_("No answer from zone %s after %d "
+ "attempts. Marking inactive.") % (self.api_url,
+ FLAGS.zone_failures_to_offline))
def _call_novatools(zone):
@@ -107,7 +107,7 @@ class ZoneManager(object):
self.zone_states = {}
def get_zone_list(self):
- return [ zone.to_dict() for zone in self.zone_states.values() ]
+ return [zone.to_dict() for zone in self.zone_states.values()]
def _refresh_from_db(self, context):
"""Make our zone state map match the db."""
@@ -125,7 +125,7 @@ class ZoneManager(object):
for zone_id in self.zone_states.keys():
if zone_id not in db_keys:
del self.zone_states[zone_id]
-
+
def _poll_zones(self, context):
"""Try to connect to each child zone and get update."""
green_pool = GreenPool()
@@ -134,7 +134,7 @@ class ZoneManager(object):
def ping(self, context=None):
"""Ping should be called periodically to update zone status."""
diff = datetime.now() - self.last_zone_db_check
- if diff.seconds >= FLAGS.zone_db_check_interval:
+ if diff.seconds >= FLAGS.zone_db_check_interval:
logging.debug("Updating zone cache from db.")
self.last_zone_db_check = datetime.now()
self._refresh_from_db(context)
diff --git a/nova/tests/test_zones.py b/nova/tests/test_zones.py
index 2cb070aca..7036ebe58 100644
--- a/nova/tests/test_zones.py
+++ b/nova/tests/test_zones.py
@@ -67,7 +67,7 @@ class ZoneManagerTestCase(test.TestCase):
FakeZone(id=1, api_url='http://foo.com', username='user1',
password='pass1'),
])
-
+
self.assertEquals(len(zm.zone_states), 0)
self.mox.ReplayAll()
@@ -89,7 +89,7 @@ class ZoneManagerTestCase(test.TestCase):
FakeZone(id=1, api_url='http://foo.com', username='user2',
password='pass2'),
])
-
+
self.assertEquals(len(zm.zone_states), 1)
self.mox.ReplayAll()
@@ -107,8 +107,8 @@ class ZoneManagerTestCase(test.TestCase):
zm.zone_states[1] = zone_state
self.mox.StubOutWithMock(db, 'zone_get_all')
- db.zone_get_all(mox.IgnoreArg()).AndReturn([ ])
-
+ db.zone_get_all(mox.IgnoreArg()).AndReturn([])
+
self.assertEquals(len(zm.zone_states), 1)
self.mox.ReplayAll()
@@ -125,7 +125,7 @@ class ZoneManagerTestCase(test.TestCase):
zm.zone_states[1] = zone_state
self.mox.StubOutWithMock(db, 'zone_get_all')
-
+
db.zone_get_all(mox.IgnoreArg()).AndReturn([
FakeZone(id=2, api_url='http://foo.com', username='user2',
password='pass2'),