Add unit tests for nova.volume.cinder.API

Fixes bug 1042215

Change-Id: I281f56c5a247b4af4e91182be13f5fcd6772917c

1 files changed, 281 insertions, 0 deletions

diff --git a/nova/tests/volume/test_cinder.py b/nova/tests/volume/test_cinder.py
new file mode 100644
index 000000000..78d2602cc
--- /dev/null
+++ b/nova/tests/volume/test_cinder.py
@@ -0,0 +1,281 @@
+# vim: tabstop=4 shiftwidth=4 softtabstop=4
+
+# Copyright 2013 Mirantis, Inc.
+# Copyright 2013 OpenStack Foundation
+#
+#    Licensed under the Apache License, Version 2.0 (the "License"); you may
+#    not use this file except in compliance with the License. You may obtain
+#    a copy of the License at
+#
+#         http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+#    License for the specific language governing permissions and limitations
+#    under the License.
+
+from cinderclient import exceptions as cinder_exception
+
+from nova import context
+from nova import exception
+from nova import test
+from nova.volume import cinder
+
+
+class FakeCinderClient(object):
+    class Volumes(object):
+        def get(self, volume_id):
+            return {'id': volume_id}
+
+        def list(self, detailed):
+            return [{'id': 'id1'}, {'id': 'id2'}]
+
+        def create(self, *args, **kwargs):
+            return {'id': 'created_id'}
+
+        def __getattr__(self, item):
+            return None
+
+    def __init__(self):
+        self.volumes = self.Volumes()
+        self.volume_snapshots = self.volumes
+
+
+class CinderApiTestCase(test.TestCase):
+    def setUp(self):
+        super(CinderApiTestCase, self).setUp()
+
+        self.api = cinder.API()
+        self.cinderclient = FakeCinderClient()
+        self.ctx = context.get_admin_context()
+        self.mox.StubOutWithMock(cinder, 'cinderclient')
+        self.mox.StubOutWithMock(cinder, '_untranslate_volume_summary_view')
+        self.mox.StubOutWithMock(cinder, '_untranslate_snapshot_summary_view')
+
+    def test_get(self):
+        volume_id = 'volume_id1'
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_volume_summary_view(self.ctx, {'id': 'volume_id1'})
+        self.mox.ReplayAll()
+
+        self.api.get(self.ctx, volume_id)
+
+    def test_get_failed(self):
+        volume_id = 'volume_id'
+        cinder.cinderclient(self.ctx).AndRaise(cinder_exception.NotFound(''))
+        cinder.cinderclient(self.ctx).AndRaise(cinder_exception.BadRequest(''))
+        self.mox.ReplayAll()
+
+        self.assertRaises(exception.VolumeNotFound,
+                          self.api.get, self.ctx, volume_id)
+        self.assertRaises(exception.InvalidInput,
+                          self.api.get, self.ctx, volume_id)
+
+    def test_create(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_volume_summary_view(self.ctx, {'id': 'created_id'})
+        self.mox.ReplayAll()
+
+        self.api.create(self.ctx, 1, '', '')
+
+    def test_create_failed(self):
+        cinder.cinderclient(self.ctx).AndRaise(cinder_exception.NotFound(''))
+        self.mox.ReplayAll()
+
+        self.assertRaises(exception.VolumeNotFound,
+                          self.api.create, self.ctx, 1, '', '')
+
+    def test_get_all(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_volume_summary_view(self.ctx,
+                                                {'id': 'id1'}).AndReturn('id1')
+        cinder._untranslate_volume_summary_view(self.ctx,
+                                                {'id': 'id2'}).AndReturn('id2')
+        self.mox.ReplayAll()
+
+        self.assertEqual(['id1', 'id2'], self.api.get_all(self.ctx))
+
+    def test_check_attach_volume_status_error(self):
+        volume = {'status': 'error'}
+        self.assertRaises(exception.InvalidVolume,
+                          self.api.check_attach, self.ctx, volume)
+
+    def test_check_attach_volume_already_attached(self):
+        volume = {'status': 'available'}
+        volume['attach_status'] = "attached"
+        self.assertRaises(exception.InvalidVolume,
+                          self.api.check_attach, self.ctx, volume)
+
+    def test_check_attach_availability_zone_differs(self):
+        volume = {'status': 'available'}
+        volume['attach_status'] = "detached"
+        instance = {'availability_zone': 'zone1'}
+        volume['availability_zone'] = 'zone2'
+        cinder.CONF.set_override('cinder_cross_az_attach', False)
+        self.assertRaises(exception.InvalidVolume,
+                          self.api.check_attach, self.ctx, volume, instance)
+        volume['availability_zone'] = 'zone1'
+        self.assertIsNone(self.api.check_attach(self.ctx, volume, instance))
+        cinder.CONF.reset()
+
+    def test_check_attach(self):
+        volume = {'status': 'available'}
+        volume['attach_status'] = "detached"
+        volume['availability_zone'] = 'zone1'
+        instance = {'availability_zone': 'zone1'}
+        cinder.CONF.set_override('cinder_cross_az_attach', False)
+        self.assertIsNone(self.api.check_attach(self.ctx, volume, instance))
+        cinder.CONF.reset()
+
+    def test_check_detach(self):
+        volume = {'status': 'available'}
+        self.assertRaises(exception.InvalidVolume,
+                          self.api.check_detach, self.ctx, volume)
+        volume['status'] = 'non-available'
+        self.assertIsNone(self.api.check_detach(self.ctx, volume))
+
+    def test_reserve_volume(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'reserve')
+        self.cinderclient.volumes.reserve('id1')
+        self.mox.ReplayAll()
+
+        self.api.reserve_volume(self.ctx, {'id': 'id1'})
+
+    def test_unreserve_volume(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'unreserve')
+        self.cinderclient.volumes.unreserve('id1')
+        self.mox.ReplayAll()
+
+        self.api.unreserve_volume(self.ctx, {'id': 'id1'})
+
+    def test_begin_detaching(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'begin_detaching')
+        self.cinderclient.volumes.begin_detaching('id1')
+        self.mox.ReplayAll()
+
+        self.api.begin_detaching(self.ctx, {'id': 'id1'})
+
+    def test_roll_detaching(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'roll_detaching')
+        self.cinderclient.volumes.roll_detaching('id1')
+        self.mox.ReplayAll()
+
+        self.api.roll_detaching(self.ctx, {'id': 'id1'})
+
+    def test_attach(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'attach')
+        self.cinderclient.volumes.attach('id1', 'uuid', 'point')
+        self.mox.ReplayAll()
+
+        self.api.attach(self.ctx, {'id': 'id1'}, 'uuid', 'point')
+
+    def test_detach(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'detach')
+        self.cinderclient.volumes.detach('id1')
+        self.mox.ReplayAll()
+
+        self.api.detach(self.ctx, {'id': 'id1'})
+
+    def test_initialize_connection(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'initialize_connection')
+        self.cinderclient.volumes.initialize_connection('id1', 'connector')
+        self.mox.ReplayAll()
+
+        self.api.initialize_connection(self.ctx, {'id': 'id1'}, 'connector')
+
+    def test_terminate_connection(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'terminate_connection')
+        self.cinderclient.volumes.terminate_connection('id1', 'connector')
+        self.mox.ReplayAll()
+
+        self.api.terminate_connection(self.ctx, {'id': 'id1'}, 'connector')
+
+    def test_delete(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volumes,
+                                 'delete')
+        self.cinderclient.volumes.delete('id1')
+        self.mox.ReplayAll()
+
+        self.api.delete(self.ctx, {'id': 'id1'})
+
+    def test_update(self):
+        self.assertRaises(NotImplementedError,
+                          self.api.update, self.ctx, '', '')
+
+    def test_get_snapshot(self):
+        snapshot_id = 'snapshot_id'
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_snapshot_summary_view(self.ctx,
+                                                  {'id': snapshot_id})
+        self.mox.ReplayAll()
+
+        self.api.get_snapshot(self.ctx, snapshot_id)
+
+    def test_get_all_snapshots(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_snapshot_summary_view(self.ctx,
+                                                {'id': 'id1'}).AndReturn('id1')
+        cinder._untranslate_snapshot_summary_view(self.ctx,
+                                                {'id': 'id2'}).AndReturn('id2')
+        self.mox.ReplayAll()
+
+        self.assertEqual(['id1', 'id2'], self.api.get_all_snapshots(self.ctx))
+
+    def test_create_snapshot(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_snapshot_summary_view(self.ctx,
+                                                  {'id': 'created_id'})
+        self.mox.ReplayAll()
+
+        self.api.create_snapshot(self.ctx, {'id': 'id1'}, '', '')
+
+    def test_create_force(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        cinder._untranslate_snapshot_summary_view(self.ctx,
+                                                  {'id': 'created_id'})
+        self.mox.ReplayAll()
+
+        self.api.create_snapshot_force(self.ctx, {'id': 'id1'}, '', '')
+
+    def test_delete_snapshot(self):
+        cinder.cinderclient(self.ctx).AndReturn(self.cinderclient)
+        self.mox.StubOutWithMock(self.cinderclient.volume_snapshots,
+                                 'delete')
+        self.cinderclient.volume_snapshots.delete('id1')
+        self.mox.ReplayAll()
+
+        self.api.delete_snapshot(self.ctx, {'id': 'id1'})
+
+    def test_get_volume_metadata(self):
+        self.assertRaises(NotImplementedError,
+                          self.api.get_volume_metadata, self.ctx, '')
+
+    def test_get_volume_metadata_value(self):
+        self.assertRaises(NotImplementedError,
+                          self.api.get_volume_metadata_value, '', '')
+
+    def test_delete_volume_metadata(self):
+        self.assertRaises(NotImplementedError,
+                          self.api.delete_volume_metadata, self.ctx, '', '')
+
+    def test_update_volume_metadata(self):
+        self.assertRaises(NotImplementedError,
+                          self.api.update_volume_metadata, self.ctx, '', '')