diff options
| author | Vishvananda Ishaya <vishvananda@gmail.com> | 2010-08-06 15:48:46 -0700 |
|---|---|---|
| committer | Vishvananda Ishaya <vishvananda@gmail.com> | 2010-08-06 15:48:46 -0700 |
| commit | a33dce2da8dc8e25d0943732adfa6b14b1e48c7b (patch) | |
| tree | d10f5c6cd09a114e1a51aa336cc7fb658211796d | |
| parent | 98ea9c02f60dc6734707bfc3827e6fe82dfde127 (diff) | |
| download | nova-a33dce2da8dc8e25d0943732adfa6b14b1e48c7b.tar.gz nova-a33dce2da8dc8e25d0943732adfa6b14b1e48c7b.tar.xz nova-a33dce2da8dc8e25d0943732adfa6b14b1e48c7b.zip | |
a few more commands were putting output on stderr. In general, exceptions on stderr output seems like a bad idea
| -rw-r--r-- | nova/volume/service.py | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/nova/volume/service.py b/nova/volume/service.py index 9c52ee469..66163a812 100644 --- a/nova/volume/service.py +++ b/nova/volume/service.py @@ -128,8 +128,8 @@ class VolumeService(service.Service): def _restart_exports(self): if FLAGS.fake_storage: return - yield process.simple_execute("sudo vblade-persist auto all") - # NOTE(vish): this command sometimes sends output to stderr for warnings + # NOTE(vish): these commands sometimes sends output to stderr for warnings + yield process.simple_execute("sudo vblade-persist auto all", error_ok=1) yield process.simple_execute("sudo vblade-persist start all", error_ok=1) @defer.inlineCallbacks @@ -243,7 +243,8 @@ class Volume(datastore.BasicModel): yield process.simple_execute( "sudo lvcreate -L %s -n %s %s" % (sizestr, self['volume_id'], - FLAGS.volume_group)) + FLAGS.volume_group), + error_ok=1) @defer.inlineCallbacks def _delete_lv(self): @@ -277,7 +278,7 @@ class Volume(datastore.BasicModel): self['blade_id'], FLAGS.aoe_eth_dev, FLAGS.volume_group, - self['volume_id'])) + self['volume_id']), error_ok=1) @defer.inlineCallbacks def _remove_export(self): |