summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSoren Hansen <soren@linux2go.dk>2011-03-10 09:55:45 +0100
committerSoren Hansen <soren@linux2go.dk>2011-03-10 09:55:45 +0100
commit9e77a0c6f6b43494e0eb87a16f33cd566f0746d2 (patch)
tree532dead5116f5eb6c8421c57b01868400b9fcb60
parent1fa41c5c621f3190c8c2b1c3d885c95b6b627b23 (diff)
downloadnova-9e77a0c6f6b43494e0eb87a16f33cd566f0746d2.tar.gz
nova-9e77a0c6f6b43494e0eb87a16f33cd566f0746d2.tar.xz
nova-9e77a0c6f6b43494e0eb87a16f33cd566f0746d2.zip
Split dnsmasq and radvd commands into their respective argv's.
-rw-r--r--nova/network/linux_net.py38
1 files changed, 19 insertions, 19 deletions
diff --git a/nova/network/linux_net.py b/nova/network/linux_net.py
index 228a4d9ea..9fd6c82de 100644
--- a/nova/network/linux_net.py
+++ b/nova/network/linux_net.py
@@ -424,30 +424,30 @@ def _remove_rule(chain, *cmd):
def _dnsmasq_cmd(net):
"""Builds dnsmasq command"""
- cmd = ['sudo -E dnsmasq',
- ' --strict-order',
- ' --bind-interfaces',
- ' --conf-file=',
- ' --domain=%s' % FLAGS.dhcp_domain,
- ' --pid-file=%s' % _dhcp_file(net['bridge'], 'pid'),
- ' --listen-address=%s' % net['gateway'],
- ' --except-interface=lo',
- ' --dhcp-range=%s,static,120s' % net['dhcp_start'],
- ' --dhcp-hostsfile=%s' % _dhcp_file(net['bridge'], 'conf'),
- ' --dhcp-script=%s' % FLAGS.dhcpbridge,
- ' --leasefile-ro']
+ cmd = ['sudo', '-E', 'dnsmasq',
+ '--strict-order',
+ '--bind-interfaces',
+ '--conf-file=',
+ '--domain=%s' % FLAGS.dhcp_domain,
+ '--pid-file=%s' % _dhcp_file(net['bridge'], 'pid'),
+ '--listen-address=%s' % net['gateway'],
+ '--except-interface=lo',
+ '--dhcp-range=%s,static,120s' % net['dhcp_start'],
+ '--dhcp-hostsfile=%s' % _dhcp_file(net['bridge'], 'conf'),
+ '--dhcp-script=%s' % FLAGS.dhcpbridge,
+ '--leasefile-ro']
if FLAGS.dns_server:
- cmd.append(' -h -R --server=%s' % FLAGS.dns_server)
- return ''.join(cmd)
+ cmd += ['-h', '-R', '--server=%s' % FLAGS.dns_server]
+ return cmd
def _ra_cmd(net):
"""Builds radvd command"""
- cmd = ['sudo -E radvd',
-# ' -u nobody',
- ' -C %s' % _ra_file(net['bridge'], 'conf'),
- ' -p %s' % _ra_file(net['bridge'], 'pid')]
- return ''.join(cmd)
+ cmd = ['sudo', '-E', 'radvd',
+# '-u', 'nobody',
+ '-C', '%s' % _ra_file(net['bridge'], 'conf'),
+ '-p', '%s' % _ra_file(net['bridge'], 'pid')]
+ return cmd
def _stop_dnsmasq(network):