diff options
author | Ken Pepple <ken.pepple@gmail.com> | 2011-04-08 08:04:57 +0000 |
---|---|---|
committer | Tarmac <> | 2011-04-08 08:04:57 +0000 |
commit | 94e35cb15f487ab313c403e023ce84b320ab480c (patch) | |
tree | 893dccedc43c37540d0c0cddad48a6a7cfd86e90 | |
parent | 428bc567872e2668e774681a58902610af11aacd (diff) | |
parent | f2928ba331234f53e3051cf0ea1a5492593bedf1 (diff) | |
download | nova-94e35cb15f487ab313c403e023ce84b320ab480c.tar.gz nova-94e35cb15f487ab313c403e023ce84b320ab480c.tar.xz nova-94e35cb15f487ab313c403e023ce84b320ab480c.zip |
corrects incorrect openstack api responses for metadata (numeric/string conversion issue) and image format status (not uppercase)
-rw-r--r-- | nova/api/openstack/views/images.py | 10 | ||||
-rw-r--r-- | nova/api/openstack/views/servers.py | 2 | ||||
-rw-r--r-- | nova/tests/api/openstack/test_servers.py | 4 |
3 files changed, 8 insertions, 8 deletions
diff --git a/nova/api/openstack/views/images.py b/nova/api/openstack/views/images.py index 16195b050..9dec8a355 100644 --- a/nova/api/openstack/views/images.py +++ b/nova/api/openstack/views/images.py @@ -34,11 +34,11 @@ class ViewBuilder(object): def _format_status(self, image): """Update the status field to standardize format.""" status_mapping = { - 'pending': 'queued', - 'decrypting': 'preparing', - 'untarring': 'saving', - 'available': 'active', - 'killed': 'failed', + 'pending': 'QUEUED', + 'decrypting': 'PREPARING', + 'untarring': 'SAVING', + 'available': 'ACTIVE', + 'killed': 'FAILED', } try: diff --git a/nova/api/openstack/views/servers.py b/nova/api/openstack/views/servers.py index 59a0ab06f..e52bfaea3 100644 --- a/nova/api/openstack/views/servers.py +++ b/nova/api/openstack/views/servers.py @@ -82,7 +82,7 @@ class ViewBuilder(object): # Return the metadata as a dictionary metadata = {} for item in inst.get('metadata', []): - metadata[item['key']] = item['value'] + metadata[item['key']] = str(item['value']) inst_dict['metadata'] = metadata inst_dict['hostId'] = '' diff --git a/nova/tests/api/openstack/test_servers.py b/nova/tests/api/openstack/test_servers.py index f10bc1d7b..34513734b 100644 --- a/nova/tests/api/openstack/test_servers.py +++ b/nova/tests/api/openstack/test_servers.py @@ -751,7 +751,7 @@ class ServersTest(test.TestCase): self.assertEqual(s['imageId'], '10') self.assertEqual(s['flavorId'], 1) self.assertEqual(s['status'], 'BUILD') - self.assertEqual(s['metadata']['seq'], i) + self.assertEqual(s['metadata']['seq'], str(i)) def test_get_all_server_details_v1_1(self): req = webob.Request.blank('/v1.1/servers/detail') @@ -765,7 +765,7 @@ class ServersTest(test.TestCase): self.assertEqual(s['imageRef'], 'http://localhost/v1.1/images/10') self.assertEqual(s['flavorRef'], 'http://localhost/v1.1/flavors/1') self.assertEqual(s['status'], 'BUILD') - self.assertEqual(s['metadata']['seq'], i) + self.assertEqual(s['metadata']['seq'], str(i)) def test_get_all_server_details_with_host(self): ''' |