diff options
| author | Soren Hansen <soren@linux2go.dk> | 2011-06-21 18:42:57 +0000 |
|---|---|---|
| committer | Tarmac <> | 2011-06-21 18:42:57 +0000 |
| commit | 7cb4d3150bf0883944624d46bc458cfd25fa1c9a (patch) | |
| tree | dce2d4232866a83618066883f00f92907295d555 | |
| parent | 29e2d55e9d47dd4abffdb871ee88af9083d022d1 (diff) | |
| parent | 652ccbd3d255c5c95337d874b9cba10f0ce40ebb (diff) | |
| download | nova-7cb4d3150bf0883944624d46bc458cfd25fa1c9a.tar.gz nova-7cb4d3150bf0883944624d46bc458cfd25fa1c9a.tar.xz nova-7cb4d3150bf0883944624d46bc458cfd25fa1c9a.zip | |
Stop trying to set a body for HTTP methods that do not allow it. It renders the unit tests useless (since they're testing a situation that can never arise) and webob 1.0.8 fails if you do this.
| -rw-r--r-- | nova/tests/api/openstack/test_limits.py | 3 | ||||
| -rw-r--r-- | nova/tests/api/openstack/test_servers.py | 2 | ||||
| -rw-r--r-- | nova/tests/api/openstack/test_wsgi.py | 4 | ||||
| -rw-r--r-- | tools/pip-requires | 2 |
4 files changed, 5 insertions, 6 deletions
diff --git a/nova/tests/api/openstack/test_limits.py b/nova/tests/api/openstack/test_limits.py index 01613d1d8..38c959fae 100644 --- a/nova/tests/api/openstack/test_limits.py +++ b/nova/tests/api/openstack/test_limits.py @@ -672,8 +672,7 @@ class WsgiLimiterTest(BaseLimitTestSuite): """Only POSTs should work.""" requests = [] for method in ["GET", "PUT", "DELETE", "HEAD", "OPTIONS"]: - request = webob.Request.blank("/") - request.body = self._request_data("GET", "/something") + request = webob.Request.blank("/", method=method) response = request.get_response(self.app) self.assertEqual(response.status_int, 405) diff --git a/nova/tests/api/openstack/test_servers.py b/nova/tests/api/openstack/test_servers.py index 05de6e2a9..b53c6c9be 100644 --- a/nova/tests/api/openstack/test_servers.py +++ b/nova/tests/api/openstack/test_servers.py @@ -1502,7 +1502,7 @@ class ServersTest(test.TestCase): self.assertEqual(res.status_int, 400) def test_resized_server_has_correct_status(self): - req = self.webreq('/1', 'GET', dict(resize=dict(flavorId=3))) + req = self.webreq('/1', 'GET') def fake_migration_get(*args): return {} diff --git a/nova/tests/api/openstack/test_wsgi.py b/nova/tests/api/openstack/test_wsgi.py index 2fa50ac9b..73a26a087 100644 --- a/nova/tests/api/openstack/test_wsgi.py +++ b/nova/tests/api/openstack/test_wsgi.py @@ -10,13 +10,13 @@ from nova.api.openstack import wsgi class RequestTest(test.TestCase): def test_content_type_missing(self): - request = wsgi.Request.blank('/tests/123') + request = wsgi.Request.blank('/tests/123', method='POST') request.body = "<body />" self.assertRaises(exception.InvalidContentType, request.get_content_type) def test_content_type_unsupported(self): - request = wsgi.Request.blank('/tests/123') + request = wsgi.Request.blank('/tests/123', method='POST') request.headers["Content-Type"] = "text/html" request.body = "asdf<br />" self.assertRaises(exception.InvalidContentType, diff --git a/tools/pip-requires b/tools/pip-requires index 7849dbea9..0da473109 100644 --- a/tools/pip-requires +++ b/tools/pip-requires @@ -15,7 +15,7 @@ python-daemon==1.5.5 python-gflags==1.3 redis==2.0.0 routes==1.12.3 -WebOb==0.9.8 +WebOb==1.0.8 wsgiref==0.1.2 mox==0.5.3 greenlet==0.3.1 |