summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJohn Tran <jtran@attinteractive.com>2011-07-26 10:03:16 -0700
committerJohn Tran <jtran@attinteractive.com>2011-07-26 10:03:16 -0700
commit6fb2fe901bc4f4479e6a2bb087870927be7318a2 (patch)
treefe3b5a86b41dae175fba25898cc07e323c46ce85
parent05e7aedaa3124267450e2f74ca026680b15d6d27 (diff)
downloadnova-6fb2fe901bc4f4479e6a2bb087870927be7318a2.tar.gz
nova-6fb2fe901bc4f4479e6a2bb087870927be7318a2.tar.xz
nova-6fb2fe901bc4f4479e6a2bb087870927be7318a2.zip
added warning when size of subnet(s) being created are larger than FLAG.network_size in attempt to alleviate confusion. For example, currently when 'nova-manage network create foo 192.168.0.0/16', the result is that it creates a 192.168.0.0/24 instead without any indication to why.
-rwxr-xr-xbin/nova-manage9
1 files changed, 9 insertions, 0 deletions
diff --git a/bin/nova-manage b/bin/nova-manage
index b63bd326f..da9538e39 100755
--- a/bin/nova-manage
+++ b/bin/nova-manage
@@ -56,6 +56,7 @@
import gettext
import glob
import json
+import math
import netaddr
import os
import sys
@@ -669,6 +670,14 @@ class NetworkCommands(object):
num_networks = FLAGS.num_networks
if not network_size:
network_size = FLAGS.network_size
+ fixnet = netaddr.IPNetwork(fixed_range)
+ each_subnet_size = fixnet.size / int(num_networks)
+ if each_subnet_size > network_size:
+ subnet = 32 - int(math.log(network_size, 2))
+ oversize_msg = _('Subnet(s) too large, defaulting to /%s.'
+ ' To override, specify network_size flag.'
+ % subnet)
+ print oversize_msg
if not multi_host:
multi_host = FLAGS.multi_host
else: