diff options
author | Naveed Massjouni <naveedm9@gmail.com> | 2011-05-06 20:15:06 -0400 |
---|---|---|
committer | Naveed Massjouni <naveedm9@gmail.com> | 2011-05-06 20:15:06 -0400 |
commit | 65595766706631a5c65193cfc0fa2ac9de1aeffc (patch) | |
tree | 03ae306611818c3a3fd5a5f0efbfbde03adb9e31 | |
parent | 3ee0507ddc6bb7e15834144acc47c354396fbc70 (diff) | |
download | nova-65595766706631a5c65193cfc0fa2ac9de1aeffc.tar.gz nova-65595766706631a5c65193cfc0fa2ac9de1aeffc.tar.xz nova-65595766706631a5c65193cfc0fa2ac9de1aeffc.zip |
Set publish_errors default to False.
-rw-r--r-- | nova/log.py | 2 | ||||
-rw-r--r-- | nova/tests/test_notifier.py | 9 |
2 files changed, 7 insertions, 4 deletions
diff --git a/nova/log.py b/nova/log.py index 3e587891a..d2ed82c6c 100644 --- a/nova/log.py +++ b/nova/log.py @@ -64,7 +64,7 @@ flags.DEFINE_list('default_log_levels', 'eventlet.wsgi.server=WARN'], 'list of logger=LEVEL pairs') flags.DEFINE_bool('use_syslog', False, 'output to syslog') -flags.DEFINE_bool('publish_errors', True, 'publish error events') +flags.DEFINE_bool('publish_errors', False, 'publish error events') flags.DEFINE_string('logfile', None, 'output to named file') diff --git a/nova/tests/test_notifier.py b/nova/tests/test_notifier.py index d18d3bc05..c9c4ddde8 100644 --- a/nova/tests/test_notifier.py +++ b/nova/tests/test_notifier.py @@ -18,14 +18,12 @@ import json import stubout import nova -from nova import log as logging +from nova import log from nova import flags from nova import notifier from nova.notifier import no_op_notifier from nova import test -LOG = logging.getLogger('nova.compute.api') - class NotifierTestCase(test.TestCase): """Test case for notifications""" def setUp(self): @@ -66,12 +64,17 @@ class NotifierTestCase(test.TestCase): def test_error_notification(self): self.stubs.Set(nova.flags.FLAGS, 'notification_driver', 'nova.notifier.rabbit_notifier.RabbitNotifier') + self.stubs.Set(nova.flags.FLAGS, 'publish_errors', True) + LOG = log.getLogger('nova') + LOG.setup_from_flags() + msgs = [] def mock_cast(context, topic, msg): data = json.loads(msg) msgs.append(data) self.stubs.Set(nova.rpc, 'cast', mock_cast) LOG.error('foo'); + self.assertEqual(1, len(msgs)) msg = msgs[0] self.assertEqual(msg['event_name'], 'error') self.assertEqual(msg['model']['msg'], 'foo') |