summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMatthew Hooker <matt@cloudscaling.com>2011-08-02 16:08:17 -0400
committerMatthew Hooker <matt@cloudscaling.com>2011-08-02 16:08:17 -0400
commit614895b6c93904888aab99d1507d94271d763c04 (patch)
tree476a37764ae9c4631c204a74a3ffb332ecaa3af3
parentd1891d2dd18a14535ec22a0363fd8234a01dbb8c (diff)
fix missing method call and add failing test
-rw-r--r--nova/tests/test_xenapi.py9
-rw-r--r--nova/tests/xenapi/stubs.py4
-rw-r--r--nova/virt/xenapi_conn.py2
3 files changed, 14 insertions, 1 deletions
diff --git a/nova/tests/test_xenapi.py b/nova/tests/test_xenapi.py
index 6b7d5df76..9032c82ab 100644
--- a/nova/tests/test_xenapi.py
+++ b/nova/tests/test_xenapi.py
@@ -669,6 +669,14 @@ class XenAPIVMTestCase(test.TestCase):
self.conn.spawn(instance, network_info)
return instance
+ def test_revert_migration(self):
+ instance = self._create_instance()
+ stubs.stubout_session(self.stubs, stubs.FakeSessionForMigrationTests)
+ stubs.stubout_loopingcall_start(self.stubs)
+ conn = xenapi_conn.get_connection(False)
+ conn.revert_migration(instance)
+
+
class XenAPIDiffieHellmanTestCase(test.TestCase):
"""Unit tests for Diffie-Hellman code."""
@@ -842,6 +850,7 @@ class XenAPIMigrateInstance(test.TestCase):
network_info, resize_instance=False)
+
class XenAPIImageTypeTestCase(test.TestCase):
"""Test ImageType class."""
diff --git a/nova/tests/xenapi/stubs.py b/nova/tests/xenapi/stubs.py
index 66c79d465..195e4d038 100644
--- a/nova/tests/xenapi/stubs.py
+++ b/nova/tests/xenapi/stubs.py
@@ -230,10 +230,14 @@ def stub_out_vm_methods(stubs):
def fake_spawn_rescue(self, inst):
inst._rescue = False
+ def fake_revert_migration(self, inst):
+ pass
+
stubs.Set(vmops.VMOps, "_shutdown", fake_shutdown)
stubs.Set(vmops.VMOps, "_acquire_bootlock", fake_acquire_bootlock)
stubs.Set(vmops.VMOps, "_release_bootlock", fake_release_bootlock)
stubs.Set(vmops.VMOps, "spawn_rescue", fake_spawn_rescue)
+ stubs.Set(vmops.VMOps, "revert_migration", fake_revert_migration)
class FakeSessionForVolumeTests(fake.SessionBase):
diff --git a/nova/virt/xenapi_conn.py b/nova/virt/xenapi_conn.py
index a3d0abf9f..042bf2b02 100644
--- a/nova/virt/xenapi_conn.py
+++ b/nova/virt/xenapi_conn.py
@@ -190,7 +190,7 @@ class XenAPIConnection(driver.ComputeDriver):
def revert_migration(self, instance):
"""Reverts a resize, powering back on the instance"""
- self._vmops.revert_resize(instance)
+ self._vmops.revert_migration(instance)
def finish_migration(self, instance, disk_info, network_info,
resize_instance=False):