summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnthony Young <sleepsonthefloor@gmail.com>2011-12-16 19:07:30 +0000
committerAnthony Young <sleepsonthefloor@gmail.com>2011-12-16 21:33:19 +0000
commit59193f110875026453b69ba0fc51f10692268875 (patch)
tree099af30fa14093406f35674f3c48054dd7edb5e0
parent2ea74bab8425338e33e8455f95d9ed208b1166de (diff)
Call get_instance_nw_info with elevated context, as documented in nova/network/manager.py
* Fixes Bug 904976 * Add coverage for this in associate_floating_ip unit test Change-Id: I5bc35632ca382d011eb42e738140ba54d9cdc93f
-rw-r--r--nova/compute/api.py2
-rw-r--r--nova/tests/test_compute.py3
2 files changed, 3 insertions, 2 deletions
diff --git a/nova/compute/api.py b/nova/compute/api.py
index e939de62c..0fd55f97d 100644
--- a/nova/compute/api.py
+++ b/nova/compute/api.py
@@ -1555,7 +1555,7 @@ class API(base.Base):
# accommodate the info containing floating as well as fixed ip
# addresses
fixed_ip_addrs = []
- for info in self.network_api.get_instance_nw_info(context,
+ for info in self.network_api.get_instance_nw_info(context.elevated(),
instance):
ips = info[1]['ips']
fixed_ip_addrs.extend([ip_dict['ip'] for ip_dict in ips])
diff --git a/nova/tests/test_compute.py b/nova/tests/test_compute.py
index b70f444e9..b01344463 100644
--- a/nova/tests/test_compute.py
+++ b/nova/tests/test_compute.py
@@ -1868,7 +1868,8 @@ class ComputeAPITestCase(BaseTestCase):
nw_info = fake_network.fake_get_instance_nw_info(self.stubs, 1)
- def fake_get_nw_info(self, ctxt, instance):
+ def fake_get_nw_info(cls, ctxt, instance):
+ self.assertTrue(ctxt.is_admin)
return nw_info
self.stubs.Set(nova.network.API, 'associate_floating_ip',