diff options
| author | Brian Elliott <brian.elliott@rackspace.com> | 2012-04-09 19:01:43 +0000 |
|---|---|---|
| committer | Brian Elliott <brian.elliott@rackspace.com> | 2012-04-09 19:06:03 +0000 |
| commit | 549616d12270a64548a907213c8e486bf0265dc8 (patch) | |
| tree | 67b66e6cff730640474c701c16f679f311219d40 | |
| parent | 93874bacf7ec60fbc218f7aba32691255b6ae8ce (diff) | |
| download | nova-549616d12270a64548a907213c8e486bf0265dc8.tar.gz nova-549616d12270a64548a907213c8e486bf0265dc8.tar.xz nova-549616d12270a64548a907213c8e486bf0265dc8.zip | |
bug 968452
Update test-requires to use pep8>=1.0. Removed PEP8 warning suppression
around 3-arg raises.
Change-Id: Ib4ed42adc167aa1e8078619a36b409b76b9f5d73
| -rw-r--r-- | Authors | 1 | ||||
| -rwxr-xr-x | run_tests.sh | 18 | ||||
| -rw-r--r-- | tools/test-requires | 2 |
3 files changed, 4 insertions, 17 deletions
@@ -25,6 +25,7 @@ Bilal Akhtar <bilalakhtar@ubuntu.com> Brad Hall <brad@nicira.com> Brad McConnell <bmcconne@rackspace.com> Brendan Maguire <B_Maguire@Dell.com> +Brian Elliott <brian.elliott@rackspace.com> Brian Lamar <brian.lamar@rackspace.com> Brian Schott <bschott@isi.edu> Brian Waldon <brian.waldon@rackspace.com> diff --git a/run_tests.sh b/run_tests.sh index cf7e39f0e..37f286e3a 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -112,27 +112,13 @@ function run_pep8 { echo "Running pep8 ..." # Just run PEP8 in current environment # - # NOTE(sirp): W602 (deprecated 3-arg raise) is being ignored for the - # following reasons: - # - # 1. It's needed to preserve traceback information when re-raising - # exceptions; this is needed b/c Eventlet will clear exceptions when - # switching contexts. - # - # 2. There doesn't appear to be an alternative, "pep8-tool" compatible way of doing this - # in Python 2 (in Python 3 `with_traceback` could be used). - # - # 3. Can find no corroborating evidence that this is deprecated in Python 2 - # other than what the PEP8 tool claims. It is deprecated in Python 3, so, - # perhaps the mistake was thinking that the deprecation applied to Python 2 - # as well. - pep8_opts="--ignore=W602 --repeat" + pep8_opts="--repeat" ${wrapper} pep8 ${pep8_opts} ${srcfiles} } function run_hacking { echo "Running hacking compliance testing..." - hacking_opts="--ignore=E202,W602 --repeat" + hacking_opts="--ignore=E202 --repeat" ${wrapper} python tools/hacking.py ${hacking_opts} ${srcfiles} } diff --git a/tools/test-requires b/tools/test-requires index 2395e781a..84d41e7b2 100644 --- a/tools/test-requires +++ b/tools/test-requires @@ -6,5 +6,5 @@ mox==0.5.3 nose nosexcover openstack.nose_plugin -pep8==0.6.1 +pep8>=1.0 sphinx>=1.1.2 |