diff options
| author | Johannes Erdfelt <johannes.erdfelt@rackspace.com> | 2012-04-05 17:56:04 +0000 |
|---|---|---|
| committer | Johannes Erdfelt <johannes.erdfelt@rackspace.com> | 2012-04-05 17:56:04 +0000 |
| commit | 4e4605694f02ec0c65fc1ced88c9f86dccd48dcb (patch) | |
| tree | a639f491342eb00a11e3902703fb5195041b54ca | |
| parent | a69e3efa54bd90eac8f536c477d0deaf240bdf3f (diff) | |
| download | nova-4e4605694f02ec0c65fc1ced88c9f86dccd48dcb.tar.gz nova-4e4605694f02ec0c65fc1ced88c9f86dccd48dcb.tar.xz nova-4e4605694f02ec0c65fc1ced88c9f86dccd48dcb.zip | |
Remove unused user_id and project_id parameters to fetch_image()
Change-Id: I36d3b5d849b23cd4ebf55c5a2ef8ba14e3808ee6
| -rw-r--r-- | nova/tests/xenapi/stubs.py | 3 | ||||
| -rw-r--r-- | nova/virt/xenapi/vm_utils.py | 26 |
2 files changed, 12 insertions, 17 deletions
diff --git a/nova/tests/xenapi/stubs.py b/nova/tests/xenapi/stubs.py index acfa8fb61..46a8efe5f 100644 --- a/nova/tests/xenapi/stubs.py +++ b/nova/tests/xenapi/stubs.py @@ -40,8 +40,7 @@ def stubout_firewall_driver(stubs, conn): def stubout_instance_snapshot(stubs): @classmethod - def fake_fetch_image(cls, context, session, instance, image, user, - project, type): + def fake_fetch_image(cls, context, session, instance, image, type): return [dict(vdi_type='os', vdi_uuid=_make_fake_vdi())] stubs.Set(vm_utils.VMHelper, 'fetch_image', fake_fetch_image) diff --git a/nova/virt/xenapi/vm_utils.py b/nova/virt/xenapi/vm_utils.py index 0e611e156..971a502a9 100644 --- a/nova/virt/xenapi/vm_utils.py +++ b/nova/virt/xenapi/vm_utils.py @@ -610,7 +610,7 @@ class VMHelper(xenapi.HelperBase): if filename == "": return cls.fetch_image(context, session, instance, image, - user_id, project_id, image_type) + image_type) else: return [dict(vdi_type=ImageType.to_string(image_type), vdi_uuid=None, @@ -627,10 +627,8 @@ class VMHelper(xenapi.HelperBase): if FLAGS.cache_images == False or image_type == ImageType.DISK_ISO: # If caching is disabled, we do not have to keep a copy of the # image. Fetch the image from glance. - return cls.fetch_image(context, session, - instance, instance.image_ref, - instance.user_id, instance.project_id, - image_type) + return cls.fetch_image(context, session, instance, + instance.image_ref, image_type) sr_ref = cls.safe_find_sr(session) sr_type = session.call_xenapi('SR.get_record', sr_ref)["type"] @@ -644,8 +642,8 @@ class VMHelper(xenapi.HelperBase): vdi_ref = cls.find_cached_image(session, image, sr_ref) if vdi_ref is None: - vdis = cls.fetch_image(context, session, instance, image, user_id, - project_id, image_type) + vdis = cls.fetch_image(context, session, instance, image, + image_type) vdi_ref = session.call_xenapi('VDI.get_by_uuid', vdis[0]['vdi_uuid']) session.call_xenapi('VDI.add_to_other_config', @@ -694,19 +692,18 @@ class VMHelper(xenapi.HelperBase): return vdi_return_list @classmethod - def fetch_image(cls, context, session, instance, image, _user_id, - _project_id, image_type): + def fetch_image(cls, context, session, instance, image, image_type): """Fetch image from glance based on image type. Returns: A single filename if image_type is KERNEL or RAMDISK A list of dictionaries that describe VDIs, otherwise """ if image_type == ImageType.DISK_VHD: - return cls._fetch_image_glance_vhd(context, - session, instance, image, image_type) + return cls._fetch_image_glance_vhd(context, session, instance, + image) else: - return cls._fetch_image_glance_disk(context, - session, instance, image, image_type) + return cls._fetch_image_glance_disk(context, session, instance, + image, image_type) @classmethod def _retry_glance_download_vhd(cls, context, session, image): @@ -750,8 +747,7 @@ class VMHelper(xenapi.HelperBase): raise exception.CouldNotFetchImage(image=image) @classmethod - def _fetch_image_glance_vhd(cls, context, session, instance, image, - _image_type): + def _fetch_image_glance_vhd(cls, context, session, instance, image): """Tell glance to download an image and put the VHDs into the SR Returns: A list of dictionaries that describe VDIs |
