summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJenkins <jenkins@review.openstack.org>2012-04-24 16:27:09 +0000
committerGerrit Code Review <review@openstack.org>2012-04-24 16:27:09 +0000
commit2c786ff3ad0d3fa85735d98f9927e9f92b686edb (patch)
tree2df143990fd720867fe7dd61a2556042b9df5756
parentf05841caf3dbf7e659b55513f07e9837b1cf22f6 (diff)
parent4c4c77925c5df36643b4f91cbe3b220e3551431e (diff)
downloadnova-2c786ff3ad0d3fa85735d98f9927e9f92b686edb.tar.gz
nova-2c786ff3ad0d3fa85735d98f9927e9f92b686edb.tar.xz
nova-2c786ff3ad0d3fa85735d98f9927e9f92b686edb.zip
Merge "Remove unused time keyword arg"
-rw-r--r--nova/compute/manager.py5
-rw-r--r--nova/tests/test_compute.py11
2 files changed, 3 insertions, 13 deletions
diff --git a/nova/compute/manager.py b/nova/compute/manager.py
index 6ade886a1..edc241206 100644
--- a/nova/compute/manager.py
+++ b/nova/compute/manager.py
@@ -1881,7 +1881,7 @@ class ComputeManager(manager.SchedulerDependentManager):
"""
return self.driver.get_instance_disk_info(instance_name)
- def pre_live_migration(self, context, instance_id, time=None,
+ def pre_live_migration(self, context, instance_id,
block_migration=False, disk=None):
"""Preparations for live migration at dest host.
@@ -1890,9 +1890,6 @@ class ComputeManager(manager.SchedulerDependentManager):
:param block_migration: if true, prepare for block migration
"""
- if not time:
- time = greenthread
-
# Getting instance info
instance_ref = self.db.instance_get(context, instance_id)
diff --git a/nova/tests/test_compute.py b/nova/tests/test_compute.py
index 27fadc321..e8b37ce99 100644
--- a/nova/tests/test_compute.py
+++ b/nova/tests/test_compute.py
@@ -58,14 +58,6 @@ flags.DECLARE('stub_network', 'nova.compute.manager')
flags.DECLARE('live_migration_retry_count', 'nova.compute.manager')
-class FakeTime(object):
- def __init__(self):
- self.counter = 0
-
- def sleep(self, t):
- self.counter += t
-
-
orig_rpc_call = rpc.call
orig_rpc_cast = rpc.cast
@@ -1244,9 +1236,10 @@ class ComputeTestCase(BaseTestCase):
c = context.get_admin_context()
# start test
+ self.stubs.Set(time, 'sleep', lambda t: None)
self.assertRaises(exception.FixedIpNotFoundForInstance,
self.compute.pre_live_migration,
- c, inst_ref['id'], time=FakeTime())
+ c, inst_ref['id'])
# cleanup
db.instance_destroy(c, inst_ref['id'])