summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSean Dague <sdague@linux.vnet.ibm.com>2013-01-08 17:08:09 -0500
committerSean Dague <sdague@linux.vnet.ibm.com>2013-01-09 15:47:22 -0500
commit1d350ba53792bd7fe0fd6364a2598b893ccf061c (patch)
tree8004a6087b39c46f4aade73ca548aea475ee986d
parentf4ee8bc87a2b8b4ea82ba273a9eff61e5d702665 (diff)
downloadnova-1d350ba53792bd7fe0fd6364a2598b893ccf061c.tar.gz
nova-1d350ba53792bd7fe0fd6364a2598b893ccf061c.tar.xz
nova-1d350ba53792bd7fe0fd6364a2598b893ccf061c.zip
fix N402 on tools/
fix N402 (single line docstrings should end in a period) Change-Id: I2086dfb33a6efeb6ef6edc6a326182b6deda2527
-rwxr-xr-xtools/hacking.py2
-rwxr-xr-xtools/lintstack.py2
-rwxr-xr-xtools/xenserver/vm_vdi_cleaner.py2
3 files changed, 3 insertions, 3 deletions
diff --git a/tools/hacking.py b/tools/hacking.py
index a860aa37b..7322fd071 100755
--- a/tools/hacking.py
+++ b/tools/hacking.py
@@ -297,7 +297,7 @@ def nova_docstring_one_line(physical_line):
pos = max([physical_line.find(i) for i in DOCSTRING_TRIPLE]) # start
end = max([physical_line[-4:-1] == i for i in DOCSTRING_TRIPLE]) # end
if (pos != -1 and end and len(physical_line) > pos + 4):
- if (physical_line[-5] != '.'):
+ if (physical_line[-5] not in ['.', '?', '!']):
return pos, "NOVA N402: one line docstring needs a period"
diff --git a/tools/lintstack.py b/tools/lintstack.py
index ce9b6f8a6..5c4fb0a3a 100755
--- a/tools/lintstack.py
+++ b/tools/lintstack.py
@@ -16,7 +16,7 @@
# License for the specific language governing permissions and limitations
# under the License.
-"""pylint error checking"""
+"""pylint error checking."""
import cStringIO as StringIO
import json
diff --git a/tools/xenserver/vm_vdi_cleaner.py b/tools/xenserver/vm_vdi_cleaner.py
index fb06a9c32..eeaf978b8 100755
--- a/tools/xenserver/vm_vdi_cleaner.py
+++ b/tools/xenserver/vm_vdi_cleaner.py
@@ -50,7 +50,7 @@ ALLOWED_COMMANDS = ["list-vdis", "clean-vdis", "list-instances",
def call_xenapi(xenapi, method, *args):
- """Make a call to xapi"""
+ """Make a call to xapi."""
return xenapi._session.call_xenapi(method, *args)