diff options
| author | Boris Pavlovic <boris@pavlovic.me> | 2012-12-17 13:49:18 +0400 |
|---|---|---|
| committer | Boris Pavlovic <boris@pavlovic.me> | 2012-12-23 06:38:48 +0400 |
| commit | 0fd155ba84e3ba451e5361fa732fc12aebf98ff5 (patch) | |
| tree | 8e34595373e0593398299f04a6338b6362b95054 | |
| parent | 8a1843a91a98cf5b945ed97adb82c2f820438949 (diff) | |
| download | nova-0fd155ba84e3ba451e5361fa732fc12aebf98ff5.tar.gz nova-0fd155ba84e3ba451e5361fa732fc12aebf98ff5.tar.xz nova-0fd155ba84e3ba451e5361fa732fc12aebf98ff5.zip | |
db.network_delete_safe() method performance optimization
Using query.count() instead of query.all() to count FixedIp.
blueprint db-session-cleanup
Change-Id: Ibe88765b52518112f9f16727082fd6db97ba9411
| -rw-r--r-- | nova/db/sqlalchemy/api.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/nova/db/sqlalchemy/api.py b/nova/db/sqlalchemy/api.py index 9cc3b64a1..5195a4028 100644 --- a/nova/db/sqlalchemy/api.py +++ b/nova/db/sqlalchemy/api.py @@ -2109,8 +2109,8 @@ def network_delete_safe(context, network_id): filter_by(network_id=network_id).\ filter_by(deleted=False).\ filter_by(allocated=True).\ - all() - if result: + count() + if result != 0: raise exception.NetworkInUse(network_id=network_id) network_ref = network_get(context, network_id=network_id, session=session) |