Kill some of the variables marked as unused by flakes8. This should
allow to enable F841 check in the future.
Only trivial cases with no function calls and obviously pure functions
(like datetime.now(), or len()) are cleaned up here.

Part 1, split to reduce conflicts.

Change-Id: I82854349574ec4bcb9336aba626eefdaed81a8c8

Mechanical translation of the deprecated
except x,y: construct with except x as y:
The latter works with any Python >= 2.6.
Add Hacking check.

Change-Id: I845829d97d379c1cd9b3a77e7e5786586f263b64

The smoketests currently have a dependency on gFlags. Long term, this should
be converted to use openstack.common.cfg; but in the near term, we should
record this existing dependency.

Fixes bug 1174953

Change-Id: I465abc6a4a2e8f7ebd1fe70ad239c760960a82ed

Fixes bug 1108978

Change-Id: I5113e67bad1aaafdbaa0adc202cac97ba8d0dfdb

* Includes some general tools/hacking cleanup
* Fix several N302 cases
* Disable N302 until all cases are fixed

Change-Id: Iddba07ff13e10dc41a6930749044bb8c0572d279

fix the N402 errors that have slipped in in the last 48 hrs since
starting this patch series.

fix an N401 error that our scanner current can't find because it
only looks for doc strings on classes and defs.

this is the xeno's paradox of patch series, but we're getting close.

Change-Id: I4a763bb4c812335d853eae05c72464f18ab93297

Fixes the wait_for_not_running function in smoketests/base.py so
that it short circuits when an instance ID is deleted rather than
waits 60 seconds (the timeout). Previously this function had
two problems:

 1) It used Boto's instance.update() instead of instance.update(validate=True).
 Since update() returns returns quietly if no data about the instance was
 returned (aka the instance has been deleted) it effectively made this
 function almost always wait for the timeout (60 seconds). This makes the
 tests take about a minute longer than they need to unless #2 below
 occurs...

 2) It also introduced a race condition in that... if hit just right
 the instance.state would get set to 'terminated'. Which would cause
 the loop to short circuit. This might seem correct at first glance but
 in fact causes intermittent failures in some of the netadmin tests
 because security groups can't be deleted if a running (or exiting)
 instance is still assigned to them. In fact wait_for_not_running
 was added to guard against just this in the first place!

Also, renames the base.wait_for_not_running function to be
called wait_for_deleted (that is what we are really doing here)

Change-Id: I4486995a7d9028d876366e8d7a2c845520319b86

Updates the test_003_can_mount_volume smoke test so that it
waits for the volume to show up in /proc/partitions for up
to 60 seconds before proceeding. This eliminates the need for
a hard coded sleep value which can cause intermittent test failures.

Change-Id: Ibdc56a00e141211e40068c22fc268efeba6affff

rename STD_OUT_HANDLE to STD_OUTPUT_HANDLE

Fixes LP #1033528

Change-Id: I75830dc4d6017076647e040d4485f99ee68333ff

Updates the Nova smoketests so that we use Paramiko's auto
add ssh key policy. This should help quiet down warnings like
this which we previously got when running the EC2 smoketests
with Nova:

/usr/lib/python2.7/site-packages/paramiko/client.py:95: UserWarning:
Unknown ssh-rsa host key for 172.20.0.3:
adb1c2f1fe461a35cd01283eac03d6fb

Fixes LP Bug #1064550.

Change-Id: I1611a3f6b54563b6a1d64c4f8e193a636ccb1c69