From 6f7a1d75f948f8d914e63f4ba4a24c97225689dc Mon Sep 17 00:00:00 2001 From: Vivek Trivedi Date: Fri, 11 Dec 2015 10:54:56 -0500 Subject: libnsm.a: do not close file if open failed If file open failed, no need to issue close system call in nsm_get_state and closeall. Signed-off-by: Vivek Trivedi Signed-off-by: Steve Dickson --- support/nfs/closeall.c | 3 ++- support/nsm/file.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/support/nfs/closeall.c b/support/nfs/closeall.c index 38fb162..a69bf35 100644 --- a/support/nfs/closeall.c +++ b/support/nfs/closeall.c @@ -31,6 +31,7 @@ closeall(int min) } else { int fd = sysconf(_SC_OPEN_MAX); while (--fd >= min) - (void) close(fd); + if(fd >= 0) + (void) close(fd); } } diff --git a/support/nsm/file.c b/support/nsm/file.c index 4711c2c..7a8b504 100644 --- a/support/nsm/file.c +++ b/support/nsm/file.c @@ -536,7 +536,8 @@ nsm_get_state(_Bool update) state++; update: - (void)close(fd); + if(fd >= 0) + (void)close(fd); if (update) { state += 2; -- cgit