From 55c12c837feaa909de8cbd6d5fe23378b85efeff Mon Sep 17 00:00:00 2001 From: Benjamin Coddington Date: Wed, 16 Mar 2016 11:31:40 -0400 Subject: gssd: Fix inner-loop variable reuse The var "i" is already in use iterating realmnames. Fixes: "6597e391 gssd: Don't assume the machine account will be in uppercase" Signed-off-by: Benjamin Coddington Signed-off-by: Steve Dickson --- utils/gssd/krb5_util.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/utils/gssd/krb5_util.c b/utils/gssd/krb5_util.c index 8ef8184..8dc64fe 100644 --- a/utils/gssd/krb5_util.c +++ b/utils/gssd/krb5_util.c @@ -796,7 +796,7 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, const char *tgtname, char **realmnames = NULL; char myhostname[NI_MAXHOST], targethostname[NI_MAXHOST]; char myhostad[NI_MAXHOST+1]; - int i, j, retval; + int i, j, k, retval; char *default_realm = NULL; char *realm; char *k5err = NULL; @@ -941,8 +941,8 @@ find_keytab_entry(krb5_context context, krb5_keytab kt, const char *tgtname, * moving on to the svcname */ if (strcmp(svcnames[j],"$") == 0 && !tried_upper) { - for (i = 0; myhostad[i] != '$'; ++i) { - myhostad[i] = toupper(myhostad[i]); + for (k = 0; myhostad[k] != '$'; ++k) { + myhostad[k] = toupper(myhostad[k]); } j--; tried_upper = 1; -- cgit