diff options
| author | Chuck Lever <chuck.lever@oracle.com> | 2008-09-26 16:13:45 -0400 |
|---|---|---|
| committer | Steve Dickson <steved@redhat.com> | 2008-09-26 16:13:45 -0400 |
| commit | 9b13713fa592b02da0dc79c5505fdf7002155d13 (patch) | |
| tree | 57249ffcb070f887226618c07e521194ad6f6c8f /utils/statd/callback.c | |
| parent | 2fd04076023d696e5e7ffa17998e9d32990e57bf (diff) | |
| download | nfs-utils-9b13713fa592b02da0dc79c5505fdf7002155d13.tar.gz nfs-utils-9b13713fa592b02da0dc79c5505fdf7002155d13.tar.xz nfs-utils-9b13713fa592b02da0dc79c5505fdf7002155d13.zip | |
rpc.statd: Clean up: replace "if (!(foo = rtnl))".
Static code checkers flag this kind of thing because it's easy to
confuse with "if (!(foo == rtnl))". In one of these cases, the
combination of evaluation and assignment isn't even necessary.
While we are in the neighborhood, remove an extra argument to note() that is
not called for in the passed-in format string.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
Diffstat (limited to 'utils/statd/callback.c')
| -rw-r--r-- | utils/statd/callback.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/utils/statd/callback.c b/utils/statd/callback.c index d5d036e..505fdb3 100644 --- a/utils/statd/callback.c +++ b/utils/statd/callback.c @@ -36,11 +36,9 @@ sm_notify_1_svc(struct stat_chge *argp, struct svc_req *rqstp) argp->mon_name, argp->state); /* quick check - don't bother if we're not monitoring anyone */ - /* LH - this was != MULL, meaning that if anyone _was_ in our RTNL, - * we'd never pass this point. */ - if (!(lp = rtnl)) { + if (rtnl == NULL) { note(N_WARNING, "SM_NOTIFY from %s while not monitoring any hosts.", - argp->mon_name, argp->state); + argp->mon_name); return ((void *) &result); } |