<feed xmlns='http://www.w3.org/2005/Atom'>
<title>nfs-utils.git/utils/nfsstat, branch fixrootccache</title>
<subtitle>NFS utils related patches</subtitle>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/'/>
<entry>
<title>nfs-utils: split conffile to a separate convenience lib</title>
<updated>2017-10-26T12:50:08+00:00</updated>
<author>
<name>Justin Mitchell</name>
<email>jumitche@redhat.com</email>
</author>
<published>2017-09-28T18:18:35+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=745287cca2fad6dfe63290bb8053ffe86637c18b'/>
<id>745287cca2fad6dfe63290bb8053ffe86637c18b</id>
<content type='text'>
To allow better reuse of the code we split conffile and xlog
into their own separate convenience library, then merge it
back so as to not create extra dependancies for everything

Signed-off-by: Justin Mitchell &lt;jumitche@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
To allow better reuse of the code we split conffile and xlog
into their own separate convenience library, then merge it
back so as to not create extra dependancies for everything

Signed-off-by: Justin Mitchell &lt;jumitche@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstats: fix some exit codes.</title>
<updated>2017-01-11T16:08:36+00:00</updated>
<author>
<name>NeilBrown</name>
<email>neilb@suse.com</email>
</author>
<published>2017-01-11T16:08:36+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=9e12e221ead6d869977b43a99e4a7d13a33d82ee'/>
<id>9e12e221ead6d869977b43a99e4a7d13a33d82ee</id>
<content type='text'>
"nfsstat -m" always exits with "1" (unless there is an error opening
/proc/mounts).  It should exist "0".

Also, a few usage errors cause an exit of "255" when it should probably
be "1".

Signed-off-by: NeilBrown &lt;neilb@suse.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
"nfsstat -m" always exits with "1" (unless there is an error opening
/proc/mounts).  It should exist "0".

Also, a few usage errors cause an exit of "255" when it should probably
be "1".

Signed-off-by: NeilBrown &lt;neilb@suse.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: show client rpc information correctly</title>
<updated>2016-01-16T17:30:13+00:00</updated>
<author>
<name>Kinglong Mee</name>
<email>kinglongmee@gmail.com</email>
</author>
<published>2016-01-16T17:22:37+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=2f8f24e617b9d3c20fe798fa00f268364e0aa7cc'/>
<id>2f8f24e617b9d3c20fe798fa00f268364e0aa7cc</id>
<content type='text'>
There are 59 client rpc procedures, not 60.

The order of rpc name must be the same as define of
NFSPROC4_CLNT_xx in include/linux/nfs4.h,
not nfs4_procedures in nfs4xdr.c.

Drop duplicate rpc name "getdevlist".

Reviewed-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Kinglong Mee &lt;kinglongmee@gmail.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
There are 59 client rpc procedures, not 60.

The order of rpc name must be the same as define of
NFSPROC4_CLNT_xx in include/linux/nfs4.h,
not nfs4_procedures in nfs4xdr.c.

Drop duplicate rpc name "getdevlist".

Reviewed-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Kinglong Mee &lt;kinglongmee@gmail.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: update nfs server operations</title>
<updated>2015-12-11T16:22:25+00:00</updated>
<author>
<name>Benjamin Coddington</name>
<email>bcodding@redhat.com</email>
</author>
<published>2015-12-11T16:14:49+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=6c39d9946a6fbe9a65a1194d72268fc4b75b0c6c'/>
<id>6c39d9946a6fbe9a65a1194d72268fc4b75b0c6c</id>
<content type='text'>
Signed-off-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: update nfs client operations</title>
<updated>2015-12-11T16:22:25+00:00</updated>
<author>
<name>Benjamin Coddington</name>
<email>bcodding@redhat.com</email>
</author>
<published>2015-12-11T16:13:45+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=2755d666b39ef50aa93df3d08438f604f2469eed'/>
<id>2755d666b39ef50aa93df3d08438f604f2469eed</id>
<content type='text'>
FSID_PRESENT was missing, and LAYOUTGET and GETDEVICEINFO were switched.
Update all the client operations.  Also, increase the output width a bit
and pull out a column for these longer new operation names.

Signed-off-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
FSID_PRESENT was missing, and LAYOUTGET and GETDEVICEINFO were switched.
Update all the client operations.  Also, increase the output width a bit
and pull out a column for these longer new operation names.

Signed-off-by: Benjamin Coddington &lt;bcodding@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: fix server rpc stats header</title>
<updated>2014-10-22T15:32:23+00:00</updated>
<author>
<name>Marko Myllynen</name>
<email>myllynen@redhat.com</email>
</author>
<published>2014-10-22T15:32:23+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=86d33d888cd4f23a1816d4806627271ce062d9a3'/>
<id>86d33d888cd4f23a1816d4806627271ce062d9a3</id>
<content type='text'>
linux/net/sunrpc/stats.c has:

/*
 * Get RPC server stats
 */
void svc_seq_show(struct seq_file *seq, const struct svc_stat *statp) {
...
        seq_printf(seq,
                "rpc %u %u %u %u %u\n",
                        statp-&gt;rpccnt,
                        statp-&gt;rpcbadfmt+statp-&gt;rpcbadauth+statp-&gt;rpcbadclnt,
                        statp-&gt;rpcbadfmt,
                        statp-&gt;rpcbadauth,
                        statp-&gt;rpcbadclnt);
...

But when /proc/net/rpc/nfsd contains

rpc 1 2 3 4 5

nfsstat -sv prints:

Server rpc stats:
calls      badcalls   badclnt    badauth    xdrcall
1          2          3          4          5

Change this to match the kernel:

Server rpc stats:
calls      badcalls   badfmt     badauth    badclnt
1          2          3          4          5

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1142842.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
linux/net/sunrpc/stats.c has:

/*
 * Get RPC server stats
 */
void svc_seq_show(struct seq_file *seq, const struct svc_stat *statp) {
...
        seq_printf(seq,
                "rpc %u %u %u %u %u\n",
                        statp-&gt;rpccnt,
                        statp-&gt;rpcbadfmt+statp-&gt;rpcbadauth+statp-&gt;rpcbadclnt,
                        statp-&gt;rpcbadfmt,
                        statp-&gt;rpcbadauth,
                        statp-&gt;rpcbadclnt);
...

But when /proc/net/rpc/nfsd contains

rpc 1 2 3 4 5

nfsstat -sv prints:

Server rpc stats:
calls      badcalls   badclnt    badauth    xdrcall
1          2          3          4          5

Change this to match the kernel:

Server rpc stats:
calls      badcalls   badfmt     badauth    badclnt
1          2          3          4          5

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1142842.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Reviewed-by: Christoph Hellwig &lt;hch@lst.de&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: document nfsstat io/ra server facilities</title>
<updated>2014-09-22T14:09:22+00:00</updated>
<author>
<name>Marko Myllynen</name>
<email>myllynen@redhat.com</email>
</author>
<published>2014-09-22T14:09:22+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=cfbbb7ac24f400d5a37c5fc9fd784bb81e99ed05'/>
<id>cfbbb7ac24f400d5a37c5fc9fd784bb81e99ed05</id>
<content type='text'>
Document the newly added nfsstat io/ra server facilities.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Document the newly added nfsstat io/ra server facilities.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: add server ra cache stats</title>
<updated>2014-09-22T14:01:02+00:00</updated>
<author>
<name>Marko Myllynen</name>
<email>myllynen@redhat.com</email>
</author>
<published>2014-09-22T14:01:02+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=03855a88a4f4c6803abe96c55315929d5e3a0048'/>
<id>03855a88a4f4c6803abe96c55315929d5e3a0048</id>
<content type='text'>
Add server read ahead cache statistics to nfsstat.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add server read ahead cache statistics to nfsstat.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>nfsstat: add server io stats</title>
<updated>2014-09-22T13:55:07+00:00</updated>
<author>
<name>Marko Myllynen</name>
<email>myllynen@redhat.com</email>
</author>
<published>2014-09-22T13:55:07+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=3533854d4dc44e4a4ffce00db3df8e7a91f6b323'/>
<id>3533854d4dc44e4a4ffce00db3df8e7a91f6b323</id>
<content type='text'>
Add server io statistics to nfsstat.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add server io statistics to nfsstat.

Signed-off-by: Marko Myllynen &lt;myllynen@redhat.com&gt;
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Fixed typo in nfsstat -sv output</title>
<updated>2014-09-16T13:12:36+00:00</updated>
<author>
<name>Steve Dickson</name>
<email>steved@redhat.com</email>
</author>
<published>2014-09-16T13:10:55+00:00</published>
<link rel='alternate' type='text/html' href='https://fedorapeople.org/cgit/simo/public_git/nfs-utils.git/commit/?id=0a7b6854e50eca6613f525c8e1b7978c10372863'/>
<id>0a7b6854e50eca6613f525c8e1b7978c10372863</id>
<content type='text'>
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Signed-off-by: Steve Dickson &lt;steved@redhat.com&gt;
</pre>
</div>
</content>
</entry>
</feed>
