nfs-utils.git/utils/mountd, branch gss-fixes

mountd: optimize libblkid usage

2014-01-07T20:57:48+00:00

 * use get_uuid_blkdev() only first time for the path (it means
   that uuid_by_path() is called with type==0)

 * don't use libblkid for btrfs, network or pseudo filesystems

Note that the patch defines the fs type ID rather than include
 as this file seems incomplete and libc specific).

Signed-off-by: Karel Zak 
Signed-off-by: Steve Dickson

mountd: Add the ability to disable UDP listeners.

2013-11-05T19:11:44+00:00

Add the ability to turn off UDP listeners with the
new "-u | --no-udp" flag.

Signed-off-by: Steve Dickson

mountd: Use protocol bit fields to turn protocols off.

2013-11-05T19:10:05+00:00

Convert the current code to used the NFSCTL_XXX macros
to turn off the TCP listener.

Signed-off-by: Steve Dickson

mountd: fix bug affecting exports of dirs with 64bit inode number.

2013-10-24T20:06:01+00:00

parse_fsid() is currently truncating all inode numbers to
32bits, and assumes that 'int' is 32 bits (which it probably is,
but we shouldn't assume).

So make the 'inode' field in 'struct parsed_fsid' a 64 bit field.
and only memcpy into variables or fields that have been declared
to a specific bit size.

Signed-off-by: NeilBrown 
Signed-off-by: Steve Dickson

mountd: Fix is_subdirectory again

2013-05-07T15:50:32+00:00

The problem was that is_subdirectory() would also succeed if the two
directories were the same.  This is needed for path_matches() which
needs to see if the child is same-or-descendant.

So this patch rearranges path_matches() to do the "are they the same"
test itself and only bother with is_subdirectory() if it they are not
the same.

So now is_subdirectory() can be strict, and so can be usable for
subexport(), which needs a strong 'in subdirectory - not the same' test.

Acked-by: J. Bruce Fields 
Signed-off-by: NeilBrown 
Signed-off-by: Steve Dickson

mountd: fix exporting of "/" with sec= setting.

2013-04-22T16:47:20+00:00

Commit 91bb95f2689e84856ecdf6fac365489d36709cf9
   4set_root: force "fsid=0" for all exports of '/'

set NFSEXP_FSID for the export of "/" if nothing else had any fsid set,
however it didn't also set the flag for all security flavours.  So the
kernel complains that the flags on the security flavours don't match and
it rejects the export.

So call fix_pseudoflavor_flags() in write_secinfo() to make sure that
any fiddling that has been done to e_flags gets copied to e_secinfo.

Signed-off-by: NeilBrown 
Signed-off-by: Steve Dickson

mountd: Add the missing '$' in auth_unix_ip()

2013-04-22T16:47:20+00:00

We found this problem because NFS clients to a RHEL6 NFS server were
experiencing periods of ESTALE errors after being mounted and initially
working successfully. Tests were run which snapshotted the nfs/sunrpc
caches before and after the issue, and it was found that the '$'
character
at the beginning of the ID strings, used when in use_ipaddr mode, was
getting
lost:

GOOD, while mount was working:
nfsd 1.2.3.4 $1.2.3.4

BAD, after mount started returning ESTALE:
nfsd 1.2.3.4 1.2.3.4

This would then cause the export checks to fail by passing '1.2.3.4'
instead of '$1.2.3.4' up to rpc.mountd.

The problem appears to be in the auth_unix_ip() function when renewing
the auth.unix.ip cache entry.  It would fail to add the '$' character
back to the beginning of the string used for the domain string,
breaking the use_ipaddr mode.

Signed-off-by: Jose Castillo 
Signed-off-by: Steve Dickson

mountd: regression in crossmounts

2013-03-25T14:09:11+00:00

commit 8e2fb3fc cause a regression in mount export
that are on different local file system.
Exports like (all on different filesystems)

/home *(rw,fsid=0,crossmnt)
/home/fs1 *(rw,crossmnt)
/home/fs1/fs2/fs3 *(rw,nohide)

and then a mount of the root 'mount /home /mnt'
would end up mounting /home/fs1/fs2/fs3 not /home

Reverting the logic of commit 8e2fb3fc until
a better solution can be found for the original
problem.

Signed-off-by: Steve Dickson

mountd: make local functions in v4root.c static

2013-03-25T14:09:09+00:00

Clean up.  set_pseudofs_security() and pseudofs_update() have no
call sites outside of v4root.c, and there are no header declarations
for either function.  Define both as static.

Acked-by: J. Bruce Fields 
Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mountd: remove unused variable

2013-03-25T14:09:09+00:00

Making all in mountd
cache.c: In function 'subexport':
cache.c:374:9: warning: unused variable 'l2' [-Wunused-variable]

Commit 8e2fb3fc removed the last use of "l2" in the subexport()
function.

Signed-off-by: Chuck Lever 
Acked-by: J. Bruce Fields 
Signed-off-by: Steve Dickson