nfs-utils.git/utils/mount, branch gss-fixes

mount.nfs: Don't silently ignore invalid protocol versions.

2014-01-07T20:57:48+00:00

Signed-off-by: Steve Dickson

nfs(5): Treatment of *atime mount options

2013-11-20T20:04:47+00:00

I was reminded recently that NFS treats file atime time stamps
differently than other filesystems.  It also ignores the generic
*atime mount options because it cannot support the atime semantics
of local filesystems.

We should document that somewhere.  nfs(5) seems like a logical
place for it.

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

nfs(5): Document the "migration" mount option

2013-11-20T20:04:47+00:00

Support for NFSv4 migration was merged in 3.13.

Signed-off-by: Chuck Lever 
Signed-off-by: Steve Dickson

mount.nfs: Recognize v4.x mount options

2013-11-20T20:04:47+00:00

The kernel understands text options of the form "v4.x" (ie "v4.1"), but
mount.nfs does not and this leads to weird errors when the requested
mount fails: a line in dmesg about version 3 not supporting
minorversions
and mount.nfs returning EINVAL no matter what the real error was.

This happens because mount.nfs thinks no version was specified so it
starts
probing other versions which conflicts with the v4.X option once it gets
parsed by the kernel.

$ sudo mount -v -o v4.1 zero:/invalid_export /mnt
mount.nfs: timeout set for Wed Nov 13 10:09:48 2013
mount.nfs: trying text-based options
'v4.1,vers=4,addr=192.168.100.10,clientaddr=192.168.100.11'
mount.nfs: mount(2): No such file or directory
mount.nfs: trying text-based options 'v4.1,addr=192.168.100.10'
mount.nfs: prog 100003, trying vers=3, prot=6
mount.nfs: trying 192.168.100.10 prog 100003 vers 3 prot TCP port 2049
mount.nfs: prog 100005, trying vers=3, prot=17
mount.nfs: trying 192.168.100.10 prog 100005 vers 3 prot UDP port 20048
mount.nfs: mount(2): Invalid argument
mount.nfs: an incorrect mount option was specified

And you get this in dmesg:

NFS: mount option vers=3 does not support minorversion=1

but if you use another form of the same options, this doesn't happen:

$ sudo mount -v -o vers=4,minorversion=1 zero:/invalid_export /mnt
mount.nfs: timeout set for Wed Nov 13 10:10:28 2013
mount.nfs: trying text-based options
'vers=4,minorversion=1,addr=192.168.100.10,clientaddr=192.168.100.11'
mount.nfs: mount(2): No such file or directory
mount.nfs: mounting zero:/invalid_export failed, reason given by server:
No such file or directory

Acked-by: Chuck Lever 
Signed-off-by: Weston Andros Adamson 
Signed-off-by: Steve Dickson

nfs.man: add description of multiple sec= options

2013-11-05T20:40:21+00:00

The client now supports multiple sec= options as a colon delimited list.

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Steve Dickson

statd: fix race condition for parallel startup of statd

2013-11-05T19:21:47+00:00

When start_statd figures out that statd is not yet running it starts
it, waits for the invoked process to complete, and finally verifies
that statd is working.  This approach works for serially mounting NFS
file systems but has a race condition for parallel mounting.

In the parallel case it can happen that two mount commands A and B
both decide that statd needs to be started. Both of them try to start
statd.  Obviously only one of them can successfully do so, let's
assume this is command A in our case.  The statd invoked by B
terminates because the resource is already claimed by the statd
invoked by A.  The termination of B's statd though is before the
statd of A has completely set up all things.  This causes the check
for a working statd of command B to fail and terminate the mount
request with an error.

To prevent this we define a timeout value.  In case the initial check
after invoking statd fails we try again in a loop 10 times a second
until the timeout is reached.

In our tests when the race occurred we typically were successful
already on the first retry within the loop.

Signed-off-by: Steve Dickson

mount.nfs: print an error message when remount attempt fails

2013-10-21T17:33:21+00:00

Currently, mount.nfs returns an error code, but doesn't print anything
when this occurs.

Reported-by: Eric Doutreleau 
Signed-off-by: Jeff Layton 
Signed-off-by: Steve Dickson

nfsmount.conf: remove duplicate 'timeo' from the parsing string

2013-10-21T14:03:53+00:00

When the 'timeo' option is specified in multiple sections of
the nfsmount.conf file, each instance is added to the parsing
string. This patch make the first instance override any others.

Signed-off-by: Steve Dickson

nfsmount.conf: Remove duplicate 'bg' and 'fg' from parsing string.

2013-10-21T14:03:45+00:00

When the 'Background' and/or 'Foreground' options are set
in multiple sections of the nfsmount.conf file, each instance
gets added to the parsing string. This patch makes the first
instance of either option override the any others.

Signed-off-by: Steve Dickson

mount.nfs: improve handling of bg, fg, and sloppy in nfsmount.conf

2013-08-19T17:04:53+00:00

This patch makes 2 small improvements to the parsing of the bg, fg, and
sloppy mount options in nfsmount.conf.

1. "bg" and "fg" negate should each other.  "Background=True" should
mean "bg" and "Background=False" should mean "fg".  The same applies to
"Foreground".

2. Once we see "Sloppy=False" while parsing the configuration file we
should ignore subsequent occurrences of the sloppy option.  This will
preserve the "right-most setting wins" behavior for the sloppy mount
option.

Acked-by: Chuck Lever 
Signed-off-by: Scott Mayhew 
Signed-off-by: Steve Dickson