Prior to merge libnfsidmap leaked many private symbols that were
not defined in its API, creating an accidental ABI.
This patch renames and unhides symbols in order to match that ABI
until a cleaned up API can be established and released.

Signed-off-by: Steve Dickson <steved@redhat.com>

Modify libnfsidmap to use the now shared conffile code,
adjust the build structure to generate everything correctly,
and modify the other utils to use the merged version of libnfsidmap
instead of testing for an external dependancy.

Signed-off-by: Justin Mitchell <jumitche@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>

To allow better reuse of the code we split conffile and xlog
into their own separate convenience library, then merge it
back so as to not create extra dependancies for everything

Signed-off-by: Justin Mitchell <jumitche@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>

daemon_init() calls closeall() to close any "unneeded" file descriptors.
This causes the following issue with idmapd on systems that are
configured to have SSSD handle local users and groups:

1. During startup, rpc.idmapd calls getpwnam("nobody") and
   getgrnam("nobody")
2. sss_nss_mc_get{pw,gr}nam from libnss_sss open the cache files for
   users and groups and store the fd's in a struct sss_cli_mc_ctx.  The
   passwd cache is fd 3 and the group cache is fd 4.
3. idmapd calls daemon_init() which sets fd's 0, 1, and 2 to /dev/null
   and fd 3 to the write end of the pipe that the child uses to report
   it's startup status.  It then closes all fd's >= 4.
4. idmapd then calls event_init() which leads to epoll_create1() which
   returns 4 as the epoll fd.
6. An NFSv4 mount request comes in from a client, triggering an nfsdcb
   callback.
7. idmapd calls getgrgid_r() which leads to a call to
   sss_nss_check_header() which determines that the cache needs to be
   reinitialized.  sss_nss_mc_destroy_ctx() is called, which closes the
   ctx->fd which now corresponds to the epoll file rather than the group
   cache file.
8. event_dispatch() calls epoll_wait() with epfd=4, and -EBADF is
   returned.  idmapd logs the following error and exits with  a nonzero
   status:

rpc.idmapd[650]: main: event_dispatch returns errno 9 (Bad file descriptor)

Moving the deamon_init() call so that it happens before get{pw,gr}nam()
fixes this.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>

nfs-utils and libnfsidmap have similar configuration parsing routines.
They were the same up until nfs-utils commit 7b33590f (config: Remove
the conf_path global), where conf_init() was changed to take a path as
an argument.  With the current idmap_LDADD ordering in Makefile.am, the
conf_init() from libnfsidmap is called, resulting in the following error
along with the failure to parse idmapd.conf:

rpc.idmapd[391]: rpc.idmapd: conf_reinit: open ("(null)", O_RDONLY) failed

Placing libnfs.a first in idmap_LDADD ensures that idmapd uses the config
parsing routines from nfs-utils instead of libnfsidmap.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>

Working towards an nfs.conf library and API for system config tools,
first step, replace the conf_path global with a parameter to conf_init

Signed-off-by: Justin Mitchell <jumitche@rehat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>

Changed idmapd to read its value for the pipefs-directory from
/etc/nfs.conf rather than /etc/idmapd.conf.  All other configurations
related to id mapping still reside in /etc/idmapd.conf for now.

Added a warning to indicate that idmapd's -c option is deprecated.

Corrected a misspelling of 'configuration' in nfs.conf.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>

Describe how the NFSv4 domain name can be
now be found using the _nfsv4idmapdomain DNS
TXT record

Signed-off-by: Steve Dickson <steved@redhat.com>

In general the -h flag should at least show
a usage message

Signed-off-by: Steve Dickson <steved@redhat.com>

The C and S flags were missing for the SYNOPSIS

Signed-off-by: Steve Dickson <steved@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>