diff options
| author | olavmrk <olavmrk@a716ebb1-153a-0410-b759-cfb97c6a1b53> | 2013-03-06 12:53:59 +0000 |
|---|---|---|
| committer | olavmrk <olavmrk@a716ebb1-153a-0410-b759-cfb97c6a1b53> | 2013-03-06 12:53:59 +0000 |
| commit | b3c1478d94de17ef31c60055f76c2e56e0483c0b (patch) | |
| tree | ef28167b9552a4047220e704afd549e748f3d87e | |
| parent | 540d7e4eea558d644e2bc0a1688972736ffcbbea (diff) | |
| download | mod_auth_mellon-b3c1478d94de17ef31c60055f76c2e56e0483c0b.tar.gz mod_auth_mellon-b3c1478d94de17ef31c60055f76c2e56e0483c0b.tar.xz mod_auth_mellon-b3c1478d94de17ef31c60055f76c2e56e0483c0b.zip | |
Fix missing session release in error path during login.
We had forgotten to release the session object in one of the error paths
during login. This could result in us hanging onto the session mutex after
the request has finished, this deadlocking the server. This patch fixes
that error.
git-svn-id: https://modmellon.googlecode.com/svn/trunk@182 a716ebb1-153a-0410-b759-cfb97c6a1b53
| -rw-r--r-- | auth_mellon_handler.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/auth_mellon_handler.c b/auth_mellon_handler.c index f21f9bb..24b3d31 100644 --- a/auth_mellon_handler.c +++ b/auth_mellon_handler.c @@ -1893,6 +1893,7 @@ static int am_handle_reply_common(request_rec *r, LassoLogin *login, if(idp != NULL) { rc = am_cache_env_append(session, dir_cfg->idpattr, idp); if(rc != OK) { + am_release_request_session(r, session); lasso_login_destroy(login); return rc; } |