summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSimo Sorce <simo@redhat.com>2015-06-16 13:34:21 -0400
committerSimo Sorce <simo@redhat.com>2015-06-16 14:12:49 -0400
commit4b62c33f1c42182e3d7f72c5fa25284bb84572b7 (patch)
treee65168a8ac4d4b7dcdeb3304c4829070252d5a1e
parentb91b5d302e12f28d7135b0085f47956f4e2b1ced (diff)
downloadmod_auth_gssapi-4b62c33f1c42182e3d7f72c5fa25284bb84572b7.tar.gz
mod_auth_gssapi-4b62c33f1c42182e3d7f72c5fa25284bb84572b7.tar.xz
mod_auth_gssapi-4b62c33f1c42182e3d7f72c5fa25284bb84572b7.zip
Always require authentication with basic auth
When connection bound authentication is used, we must deny access if basci auth is used and a request does not have the basic auth header. Basic auth authenticate each and every request, so if it is missing this means such request is no more authenticated and we should not allow access based on our cached metadata in this case. Closes #41 Signed-off-by: Simo Sorce <simo@redhat.com>
-rw-r--r--src/mod_auth_gssapi.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/mod_auth_gssapi.c b/src/mod_auth_gssapi.c
index ee990c2..f345efc 100644
--- a/src/mod_auth_gssapi.c
+++ b/src/mod_auth_gssapi.c
@@ -587,7 +587,9 @@ static int mag_auth(request_rec *req)
auth_header = apr_table_get(req->headers_in, "Authorization");
if (mc) {
- if (mc->established && !auth_header) {
+ if (mc->established &&
+ (auth_header == NULL) &&
+ (mc->auth_type != AUTH_TYPE_BASIC)) {
ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, req,
"Already established context found!");
mag_set_req_data(req, cfg, mc);