From 4255a7223c8b0657e10618d73fe1488295090fc7 Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Mon, 17 Jun 2013 12:53:26 +0200 Subject: dh: Check return value of buffer_add_ssh_string(). --- src/dh.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/dh.c b/src/dh.c index e4f2062..16c15e6 100644 --- a/src/dh.c +++ b/src/dh.c @@ -765,8 +765,14 @@ int make_sessionid(ssh_session session) { ssh_log(session,SSH_LOG_WARNING,"ECDH parameted missing"); goto error; } - buffer_add_ssh_string(buf,session->next_crypto->ecdh_client_pubkey); - buffer_add_ssh_string(buf,session->next_crypto->ecdh_server_pubkey); + rc = buffer_add_ssh_string(buf,session->next_crypto->ecdh_client_pubkey); + if (rc < 0) { + goto error; + } + rc = buffer_add_ssh_string(buf,session->next_crypto->ecdh_server_pubkey); + if (rc < 0) { + goto error; + } #endif } num = make_bignum_string(session->next_crypto->k); -- cgit