From ef8246a592d374cfc6e5818365037c07ee7d7b3b Mon Sep 17 00:00:00 2001 From: "Bernhard R. Link" Date: Fri, 23 Oct 2009 22:20:16 +0200 Subject: buffer_get_data returns 0 on error, so checking buffer_get_u* for < 0 makes no sense Signed-off-by: Andreas Schneider --- libssh/agent.c | 2 +- libssh/sftp.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libssh/agent.c b/libssh/agent.c index a4e0efb..bada814 100644 --- a/libssh/agent.c +++ b/libssh/agent.c @@ -452,7 +452,7 @@ ssh_string agent_sign_data(struct ssh_session_struct *session, buffer_free(request); /* check if reply is valid */ - if (buffer_get_u8(reply, (uint8_t *) &type) < 0) { + if (buffer_get_u8(reply, (uint8_t *) &type) != sizeof(uint8_t)) { goto error; } if (agent_failed(type)) { diff --git a/libssh/sftp.c b/libssh/sftp.c index bc5e637..c6a7e57 100644 --- a/libssh/sftp.c +++ b/libssh/sftp.c @@ -303,7 +303,7 @@ sftp_packet sftp_packet_read(sftp_session sftp) { return NULL; } - if (buffer_get_u32(packet->payload, &size) < 0) { + if (buffer_get_u32(packet->payload, &size) != sizeof(uint32_t)) { buffer_free(packet->payload); SAFE_FREE(packet); sftp_leave_function(); -- cgit