From d067792e7fbf022fae122c7710482e5ef201bf9a Mon Sep 17 00:00:00 2001 From: Benjamin Dauvergne Date: Fri, 4 Dec 2009 09:05:28 +0000 Subject: in lasso_saml20_profile_export_to_query, checks return values * lasso/saml-2.0/profile.c: in lasso_saml20_profile_export_to_query, check return value of of lasso_node_build_query and lasso_query_sign. --- lasso/saml-2.0/profile.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lasso/saml-2.0/profile.c b/lasso/saml-2.0/profile.c index 320bb196..400e888c 100644 --- a/lasso/saml-2.0/profile.c +++ b/lasso/saml-2.0/profile.c @@ -1015,6 +1015,8 @@ lasso_saml20_profile_export_to_query(LassoProfile *profile, LassoNode *msg, int lasso_bad_param(NODE, msg); unsigned_query = lasso_node_build_query(msg); + goto_cleanup_if_fail_with_rc(unsigned_query != NULL, + LASSO_PROFILE_ERROR_BUILDING_QUERY_FAILED); if (profile->msg_relayState) { unsigned_query = lasso_url_add_parameters(unsigned_query, 1, "RelayState", profile->msg_relayState, NULL); @@ -1033,6 +1035,7 @@ lasso_saml20_profile_export_to_query(LassoProfile *profile, LassoNode *msg, int LASSO_DS_ERROR_PRIVATE_KEY_LOAD_FAILED); result = lasso_query_sign(unsigned_query, profile->server->signature_method, profile->server->private_key); + goto_cleanup_if_fail_with_rc(result != NULL, LASSO_PROFILE_ERROR_BUILDING_QUERY_FAILED); lasso_transfer_string(*query, result); } else { lasso_transfer_string(*query, unsigned_query); -- cgit