lasso.git/lasso/xml, branch wip

One more uninitialized value

2014-06-12T01:14:51+00:00

encode_key may be release when not initialized if va_args returns null
on the first while loop.

License: MIT
Signed-off-by: Simo Sorce

Make id mandatory

2014-06-10T12:39:07+00:00

id should always be present, return immediately if not, and make its
use not conditional.

License: MIT
Signed-off-by: Simo Sorce

Consistently check dsig_reference_ctx

2014-06-09T19:08:35+00:00

Check if this is not NULL in all cases, to avoid NULL pointer dereference.
Found by clang

License: MIT
Signed-off-by: Simo Sorce

Trim unused code

2014-06-09T19:08:35+00:00

Clang complains these values are never used, avoid even assigning them.

License: MIT
Signed-off-by: Simo Sorce

Trim dead code

2014-06-09T17:26:53+00:00

These conditions can never be reached as the list is filtered with
and and to the value of 0xff, so just drop them, they are misleading.
(Also silences checkers which were screaming of deadcode, for each and
every unmatchable value ...)

License: MIT
Signed-off-by: Simo Sorce

Fix confusing loop test

2014-06-09T17:11:01+00:00

Coverity was marking the check for tsnippet after the while loop,
confused by the check. Make it more readable, and in the process
make checkers happy too.

License: MIT
Signed-off-by: Simo Sorce

Fix some uninitialized value

2014-06-09T16:54:54+00:00

The compiler complain about these values not being initialized.
come of them do not really matter as they are only really used when
later initialized in the code and the code paths would not use them
if not initialized in a previous block, however some of these seem
real issues.
In all cases make the compiler happy so we get less noise in the build
and less false positives in code chckers.

License: MIT
Signed-off-by: Simo Sorce

Missing check for Sig_Alg value

2014-06-09T16:54:31+00:00

Initialize the sig_alg value to NULL (The compilers was complaining it may
be used initialized), but also make sure to check the re is any sig_alg at
all, otherwise return a proper error.

License: MIT
Signed-off-by: Simo Sorce

Fix uninitialized values found by Coverity

2014-06-09T15:10:07+00:00

These values where being used without being initialized at least in some edge
cases. Make Coverity happy by properly initializing them.
Some of these are real bugs, not just silencing a tool.

License: MIT
Signed-off-by: Simo Sorce

Fix format check for date

2014-06-09T15:04:44+00:00

Coverity was complaining that tm was used uninitialized, but the truth is
that a third error condition where the string passed in matches no valid
format was not handled. Just return an error in that case.

License: MIT
Signed-off-by: Simo Sorce