lasso.git, branch wip

One more uninitialized value

2014-06-12T01:14:51+00:00

encode_key may be release when not initialized if va_args returns null
on the first while loop.

License: MIT
Signed-off-by: Simo Sorce

Fix potential null dereference errors

2014-06-10T19:31:46+00:00

Ina  number of cases function inputs are not checked for NULL although
values may end up with a NULL value and then they are dereferenced
directly.
Check values in the function (or the caller) if appropriate.

License: MIT
Signed-off-by: Simo Sorce

Make id mandatory

2014-06-10T12:39:07+00:00

id should always be present, return immediately if not, and make its
use not conditional.

License: MIT
Signed-off-by: Simo Sorce

Do not dereference null pointers

2014-06-09T19:34:18+00:00

Sounds like these should all be boolean 'OR's, otherwise,
if profile is not in fact a lasso profile then profile->private_data
will be dereferenced even if it is NULL.
Found by Clang

License: MIT
Signed-off-by: Simo Sorce

Rearrange case checking to avoid compiler warnings

2014-06-09T19:34:18+00:00

The compiler was complaining that 'compa' could be uninitialized.
USe this occasion to make the code simpler to understand and assign
actually meaningful values to the variable, even though the proper
actions are not implemented yet.

License: MIT
Signed-off-by: Simo Sorce

Properly exit on error

2014-06-09T19:08:35+00:00

The rc error was being set but then it was being ignored.
Get out immediately if an Issuer can't be found.

License: MIT
Signed-off-by: Simo Sorce

Consistently check dsig_reference_ctx

2014-06-09T19:08:35+00:00

Check if this is not NULL in all cases, to avoid NULL pointer dereference.
Found by clang

License: MIT
Signed-off-by: Simo Sorce

Trim unused code

2014-06-09T19:08:35+00:00

Clang complains these values are never used, avoid even assigning them.

License: MIT
Signed-off-by: Simo Sorce

Trim dead code

2014-06-09T17:26:53+00:00

These conditions can never be reached as the list is filtered with
and and to the value of 0xff, so just drop them, they are misleading.
(Also silences checkers which were screaming of deadcode, for each and
every unmatchable value ...)

License: MIT
Signed-off-by: Simo Sorce

Fix confusing loop test

2014-06-09T17:11:01+00:00

Coverity was marking the check for tsnippet after the while loop,
confused by the check. Make it more readable, and in the process
make checkers happy too.

License: MIT
Signed-off-by: Simo Sorce