From f59478241686d75ece48e8eff6099006cf0bb1b2 Mon Sep 17 00:00:00 2001 From: Ben Kaduk Date: Wed, 27 Jun 2012 15:38:47 -0400 Subject: Avoid unsigned/signed comparison in loop condition The gid_len length is declared as an unsigned int, and loop index 'i' is a signed int. This could manifest as an infinite loop if gid_len is very large. In practice, gid_len should be small, but make 'i' the same type for consistency. --- src/lib/rpc/svc_auth_unix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src') diff --git a/src/lib/rpc/svc_auth_unix.c b/src/lib/rpc/svc_auth_unix.c index 406abf7eb..a4b87d8ff 100644 --- a/src/lib/rpc/svc_auth_unix.c +++ b/src/lib/rpc/svc_auth_unix.c @@ -66,8 +66,7 @@ gssrpc__svcauth_unix( char area_machname[MAX_MACHINE_NAME+1]; int area_gids[NGRPS]; } *area; - u_int auth_len, str_len, gid_len; - register int i; + u_int auth_len, str_len, gid_len, i; rqst->rq_xprt->xp_auth = &svc_auth_none; -- cgit