From 3d8fa6bb4012296a53fe04e486a9157a2963b644 Mon Sep 17 00:00:00 2001 From: Ken Raeburn Date: Mon, 22 Oct 2007 19:18:53 +0000 Subject: Set close-on-exec flag in most places where file descriptors are opened in our libraries (in case another application thread spawns a new process) and in the KDC programs (in case a plugin library spawns a new process). Checked calls to: open fopen THREEPARAMOPEN mkstemp socket accept dup dup2 pipe. In: util lib plugins kdc kadmin/server krb524. The various programs are less critical than the libraries, as any well-written plugin that spawns a new process should close all file descriptors it doesn't need to communicate with the new process. This approach also isn't bulletproof, as the call to set the close-on-exec flag is necessarily a separate call from creating the file descriptor, and the fork call could happen in between them. So plugins should be careful regardless of this patch; it will only reduce the window of potential lossage should a plugin be poorly written. (AFAIK there are currently no plugins that spawn processes where this would be a problem.) Update dependencies. ticket: 5561 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20143 dc483132-0cff-0310-8789-dd5450dbe970 --- src/util/support/threads.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/util/support') diff --git a/src/util/support/threads.c b/src/util/support/threads.c index 968a99554..29613fd61 100644 --- a/src/util/support/threads.c +++ b/src/util/support/threads.c @@ -1,7 +1,7 @@ /* * util/support/threads.c * - * Copyright 2004,2005,2006 by the Massachusetts Institute of Technology. + * Copyright 2004,2005,2006,2007 by the Massachusetts Institute of Technology. * All Rights Reserved. * * Export of this software from the United States of America may @@ -424,7 +424,9 @@ int krb5int_thread_support_init (void) /* stats_logfile = stderr; */ stats_logfile = fopen("/dev/tty", "w+"); if (stats_logfile == NULL) - stats_logfile = stderr; + stats_logfile = stderr; + else + set_cloexec_file(stats_logfile); #endif #ifndef ENABLE_THREADS -- cgit