From 932866ad41edf830123bdfef927f1314f3100be9 Mon Sep 17 00:00:00 2001 From: Ben Kaduk Date: Thu, 23 Aug 2012 12:38:57 -0400 Subject: Do not emit debug printfs under NODEBUG These printfs spew to the console when command-line utilities such as 'klist' and 'aklog' are run, reducing usability. These printfs can also cause application hangs. On a multiprocessor machine, when PuTTY and the ccapiserver are running on different CPUs, PuTTY appears to deadlock with three concurrent threads inside cci_debug_printf(). ticket: 7342 (new) target_version: 1.10.4 tags: pullup --- src/ccapi/common/win/cci_os_debugging.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/ccapi') diff --git a/src/ccapi/common/win/cci_os_debugging.c b/src/ccapi/common/win/cci_os_debugging.c index de31c7c39..597ac8560 100644 --- a/src/ccapi/common/win/cci_os_debugging.c +++ b/src/ccapi/common/win/cci_os_debugging.c @@ -32,7 +32,9 @@ /* ------------------------------------------------------------------------ */ void cci_os_debug_vprintf (const char *in_format, va_list in_args) { +#ifdef DEBUG printf ( "%s %ld ", timestamp(), GetCurrentThreadId() ); vprintf ( in_format, in_args ); printf ( "\n" ); +#endif } -- cgit