summaryrefslogtreecommitdiffstats
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
...
* Add static ordinals to DLL exportsJeffrey Altman2007-09-304-356/+358
| | | | | | | | | | | | | | | Add static ordinals to DLL exports in krb5_32.def, xpprof32.def gssapi32.def, and krb524.def. Not added to k5sprt32.def as all of the functions are private. Not added to krb4_32.def as the library is not supported as part of KFW. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20024 dc483132-0cff-0310-8789-dd5450dbe970
* When there is no ImagePath value for a module it indicatesJeffrey Altman2007-09-301-1/+5
| | | | | | | | | | | | | that the module has not been installed. Do not report an error to the end user for uninstalled modules. This will only annoy the user and there is probably nothing the user can do about it. Perhaps the user uninstalled the module intentionally. The fact that there is still a HKCU key remaining is not an indication that the module is in use. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20023 dc483132-0cff-0310-8789-dd5450dbe970
* Remove Krb5Cred, Krb5Ident, and Krb4Cred default configuration data fromJeffrey Altman2007-09-302-9/+45
| | | | | | | | | | | | | | | the KMM Schema. Require that modules that are installed be properly installed. Add NIM Module Registry values to the NSIS installer. These values were already being set by the Wix installer. By removing the ImagePath default, unable to load module errors will not be generated when the module has not in fact been installed. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20022 dc483132-0cff-0310-8789-dd5450dbe970
* fix documentation typoJeffrey Altman2007-09-301-1/+1
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20021 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: disable warningJeffrey Altman2007-09-301-1/+4
| | | | | | | | | | Disable the potentially uninitialized variable warning for 'ri'. The variable cannot be used when uninitialized. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20020 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: PDF user documentation updates for KFW 3.2.2Jeffrey Altman2007-09-302-0/+0
| | | | | | | | | updates for NIM 1.3.1 / KFW 3.2.2 ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20019 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Provide keyboard accelerator Jeffrey Altman2007-09-291-1/+1
| | | | | | | | | | In the Advanced mode of the Obtain New Credentials dialog the keyboard accelerator was missing. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20018 dc483132-0cff-0310-8789-dd5450dbe970
* Fix typoJeffrey Altman2007-09-291-0/+0
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20017 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Spell CheckJeffrey Altman2007-09-292-34/+34
| | | | | | | | | Correct typos. Make use of "plug-in" vs "plugin" consistent. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20016 dc483132-0cff-0310-8789-dd5450dbe970
* cc_ccache_set_principal and cc_ccache_get_principal were also ignoring theirAlexandra Ellwood2007-09-272-37/+114
| | | | | | | | credentials version inputs. ticket: 5771 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19986 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: FEATURE: APP: Notification Icon Tooltip Jeffrey Altman2007-09-273-34/+66
| | | | | | | | | | | | | | The Network Identity Manager notification icon can have a tooltip associated with it. The tooltip will be displayed to the user if she hovers the mouse cursor over the notification icon. Currently, the tooltip is used to indicate the current status of Network Identity Manager. This patch adds the name of the default identity to the tooltip. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19985 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: optimize khui_find_action()Jeffrey Altman2007-09-271-7/+9
| | | | | | | | | | | | In Network Identity Manager, when locating the action object corresponding to an action identifier using khui_find_action(), don't search through the list of standard actions if we already know that the object we are searching for is a custom action. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19984 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "Set default" sub menu to the Network Identity ManagerJeffrey Altman2007-09-2712-59/+317
| | | | | | | | | | | | | notification icon context menu. The submenu will display a list of identities that the user can select as the default identity. Each identity that is displayed in the sub menu will be colored the same way it is colored in the basic view to provide a hint as to the state of the credentials belonging to the identity. ticket: 5724 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19983 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "View all identities" option to the view menu of NetworkJeffrey Altman2007-09-279-7/+77
| | | | | | | | | | | | | Identity Manager. This option will be toggled when selected. If enabled, all the known identities will be displayed in any credentials view which uses the identity of credentials as the primary group-by field. The setting of this option is persistent. ticket: 5719 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19982 dc483132-0cff-0310-8789-dd5450dbe970
* profile library memory leaks introduced when malloc returns 0Ezra Peisach2007-09-263-2/+7
| | | | | | | | | | | | | | | | | | | | I have a modified version of valgrind that will allow me to have malloc fail in a controlled way. A number of memory leaks in error return passes exist in the profile library. They are essentially inconsequental - but my goal is to eventually create a test harness that tries to cover all code - including error returns... prof_parse.c: (profile_parse_file): Free node being created if parse_line() fails. prof_file.c (profile_open_file): free prf_data_t on malloc failure prof_tree.c (profile_create_node): The magic element must be set before calling profile_free_node for it to release memory. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19981 dc483132-0cff-0310-8789-dd5450dbe970
* Include missing fileJustin Anderson2007-09-251-0/+57
| | | | | | ticket: 5459 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19980 dc483132-0cff-0310-8789-dd5450dbe970
* Update ccapi tests to work at new location in krb5 tree. Also, test for ↵Justin Anderson2007-09-259-12/+14
| | | | | | | | platform when compiling so that KfM and KfW can use this ticket: 5459 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19979 dc483132-0cff-0310-8789-dd5450dbe970
* Document use of KRB5_CCH_CCNAME for ccache name lengthJeffrey Altman2007-09-251-4/+4
| | | | | | ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19978 dc483132-0cff-0310-8789-dd5450dbe970
* change all MAX_PATH ccname buffer lengths to KRB5_CCH_CCNAME and Jeffrey Altman2007-09-251-8/+8
| | | | | | | | document the use of KRB5_CCH_CCNAME. ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19977 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KMM: miscellaneous fixesJeffrey Altman2007-09-253-13/+17
| | | | | | | | | | | | | | | | | | | kmm_reg.c: Allocate enough memory to hold the entire PluginList multi-string plus an extra NUL if the registry value was not properly terminated. kmm_registrar.c: Do not record an error loading a module if there was no configuration for it. kmmmain.c: Avoid a race condition by sending the thread quit message instead of posting it. Do so outside of the critical section to avoid a deadlock. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19976 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KRB5: cleanup krb5funcsJeffrey Altman2007-09-251-2/+3
| | | | | | | | | | | | | | | | (1) remove an extraneous backslash from the generated FILE: ccache name. GetTempPath() always returns paths terminated with a backslash. (2) increase the max ccache name length to KRB5_CCH_CCNAME from MAX_PATH. These changes have dependencies on revisions 19891 and 19897. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19975 dc483132-0cff-0310-8789-dd5450dbe970
* More consolidation of the computation of the default ccache nameJeffrey Altman2007-09-251-29/+2
| | | | | | ticket: 5691 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19974 dc483132-0cff-0310-8789-dd5450dbe970
* cc_ccache_set_principal always returns error 227Alexandra Ellwood2007-09-251-1/+1
| | | | | | | | | Was attempting to read the new name from the reply stream. ticket: new target_version: 1.7 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19973 dc483132-0cff-0310-8789-dd5450dbe970
* Set svn:eol-style on a bunch of text-looking files that didn't have itKen Raeburn2007-09-24115-11761/+11761
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19972 dc483132-0cff-0310-8789-dd5450dbe970
* we're not using changelog files any moreKen Raeburn2007-09-242-49/+0
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19971 dc483132-0cff-0310-8789-dd5450dbe970
* Remove the broken optimization from UnicodeToANSI() that attemptedJeffrey Altman2007-09-241-5/+3
| | | | | | | | | | | | | | | | | | | | | in a stupid way to avoid to WideCharToMultiByte() call by testing to see if the second byte (not wchar) was NUL. This test works for Latin1 but not for anything more interesting. Always call WideCharToMultiByte(). I commented out the use of WC_NO_BEST_FIT_CHARS in order to provide compatibility with Windows. Windows converts the user name without that option. With the current code a principal name consisting of a single component equivalent to the Greek character Sigma and a realm name will be converted to S@REALM exactly as the "WhoAmI" command does. If WC_NO_BEST_FIT_CHARS was specified, this string would be converted to "?@REALM". ticket: 5766 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19970 dc483132-0cff-0310-8789-dd5450dbe970
* MSLSA krb5_cc module fails to check success of UNICODE string conversionsJeffrey Altman2007-09-241-13/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The MSLSA krb5_cc module was written with an assumption that probably does not hold true anymore. It assumed that all Kerberos strings although stored in wide character data structures could in fact be represented in the application's ANSI code page and that such conversions would not fail. The UnicodeToANSI() function did not check the result of WideCharToMultiByte() for success. If the conversion failed, this could result in the caller believing the contents of the output string buffer were a valid string when instead they were simply stack garbage. The UnicodeStringToMITPrinc() and KerbExternalNameToMITPrinc() functions did not check the return value of krb5_parse_name() for success. If krb5_parse_name() was passed a pointer to garbage on the stack instead of an actual principal name, this could result in the caller believing the output krb5_principal * was valid when instead it was NULL. The function CacheInfoEx2ToMITCred() is dependent on the success or failure of UnicodeStringToMITPrinc() assumed it could not fail and did not return a success or failure indication to its caller. If Microsoft a formatted ticket contains a Unicode string that can not be represented in the application's ANSI code page, this could result in a NULL pointer dereference during a call to krb5_cc_resolve("MSLSA:") or krb5_cc_retrieve(), or krb5_cc_get_principal(). With the changes in this commit, tickets containing principal names that cannot be represented in the application's ANSI code page will be hidden from the application. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19969 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: Restore Copyright removed in revision 19855Jeffrey Altman2007-09-241-0/+1
| | | | | | | | | Restore MIT Copyright removed in revision 19855. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19968 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: khm_krb5_initialize() failed to return error codeJeffrey Altman2007-09-241-4/+4
| | | | | | | | | | | | | | | | khm_krb5_initialize() is called in the krb5cred.dll and krb4cred.dll credential providers in order to ensure that the caller has references to a valid krb5_context and a valid krb5_ccache. If the krb5_cc_resolve() call failed, the error code was not being returned to the caller. Instead, success was returned which in turn would result in the caller believing the NULL krb5_ccache pointer was in fact valid. This fix resolves Microsoft's WER Event ID 432405961. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19967 dc483132-0cff-0310-8789-dd5450dbe970
* Move the removal of the vc70.pdb and vc80.pdb files to the Jeffrey Altman2007-09-2213-23/+9
| | | | | | | | | global clean rule in config/Makefile.w32. No need to replicate them in each individual Makefile. ticket: 5756 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19966 dc483132-0cff-0310-8789-dd5450dbe970
* stdint.h should only be accessed if HAVE_STDINT_H definedJeffrey Altman2007-09-221-1/+3
| | | | | | | | | stdint.h does not exist on Windows. Conditionally include it based upon HAVE_STDINT_H ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19965 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: APP: BUG: restore HideWatermark functionalityJeffrey Altman2007-09-211-1/+6
| | | | | | | | | | Restore the HideWatermark functionality that was accidently removed from ui/credwnd.c ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19964 dc483132-0cff-0310-8789-dd5450dbe970
* Removed extra newlineAlexandra Ellwood2007-09-211-1/+0
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19963 dc483132-0cff-0310-8789-dd5450dbe970
* Ignore dependency lines beginning with '#' to deal with gccTom Yu2007-09-191-0/+1
| | | | | | | | | | -fworking-directory output during make depend. ticket: 5752 target_version: 1.6.4 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19961 dc483132-0cff-0310-8789-dd5450dbe970
* Fixed bug where the lock list was getting corrupted when upgrading or Alexandra Ellwood2007-09-182-46/+87
| | | | | | | | | | downgrading a lock. Also fixed a bug where we were double-replying to the client when adding a lock that could be immediately granted. ticket: 4644 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19956 dc483132-0cff-0310-8789-dd5450dbe970
* Windows\Identity Makefile "clean" moreJeffrey Altman2007-09-1813-11/+46
| | | | | | | | | | make sure that we clean up vc70.pdb, vc80.pdb, and temporary files generated during the build process. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19955 dc483132-0cff-0310-8789-dd5450dbe970
* use ccs_callback_release() to free ccs_callback_tAlexandra Ellwood2007-09-181-1/+1
| | | | | | | ticket: 4644 status: open git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19953 dc483132-0cff-0310-8789-dd5450dbe970
* Added sanity checking so we can't dereference NULL trying to call a callbackAlexandra Ellwood2007-09-181-2/+7
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19952 dc483132-0cff-0310-8789-dd5450dbe970
* Added additional debugging error checkingAlexandra Ellwood2007-09-181-2/+4
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19951 dc483132-0cff-0310-8789-dd5450dbe970
* cci_array_move should work when the source and dest positions are equalAlexandra Ellwood2007-09-181-1/+2
| | | | | | | | Fixed so it does nothing when moving an element to its own index. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19950 dc483132-0cff-0310-8789-dd5450dbe970
* Make config.status itself update the timestamp file associated withKen Raeburn2007-09-172-2/+2
| | | | | | | autoconf.h, so that we don't need a redundant invocation of config.status during the first build. git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19937 dc483132-0cff-0310-8789-dd5450dbe970
* wix installer - permit administrative installsJeffrey Altman2007-09-141-32/+3
| | | | | | | | | remove the registration requirement for administrative installs. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19936 dc483132-0cff-0310-8789-dd5450dbe970
* In the pkinit decoders, set up things properly so that asn1buf_sync()Tom Yu2007-09-131-3/+22
| | | | | | | | | behaves correctly and isn't acting on uninitialized variables. ticket: 5704 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19935 dc483132-0cff-0310-8789-dd5450dbe970
* Before the error-message tests, make sure the host principal exists,Ken Raeburn2007-09-111-3/+5
| | | | | | | so we get consistent errors. Expect the "keytab not found" error, rather than the "principal doesn't exist" error. git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19931 dc483132-0cff-0310-8789-dd5450dbe970
* Fixed macro for cc_ccache_unlock and updated documentationAlexandra Ellwood2007-09-101-2/+2
| | | | | | ticket: 4644 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19930 dc483132-0cff-0310-8789-dd5450dbe970
* 64-bit Windows krb5int_cc_default calls to LeashJeffrey Altman2007-09-051-1/+6
| | | | | | | | AMD64 builds must load leashw64.dll not leashw32.dll ticket:new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19929 dc483132-0cff-0310-8789-dd5450dbe970
* Revise patch to avoid 32-byte overflow which remained after theTom Yu2007-09-051-2/+10
| | | | | | | | | | | initial patch. Memory written to by the IXDR macro calls had not been accounted for. Thanks to Kevin Coffman, Will Fiveash, and Nico Williams for discovering this bug and assisting with patch development. ticket: 5706 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19923 dc483132-0cff-0310-8789-dd5450dbe970
* MSI installer for 64-bit AMD64Jeffrey Altman2007-09-059-314/+687
| | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for building 64-bit AMD64 MSI install packages in addition to 32-bit i386 MSI install packages. Differences between 32-bit MSI and 64-bit MSI include: * no krb4 binaries and libraries * no kclient binaries and libraries * no krb524 binaries and libraries * no leash32.exe * new AMD64 UpgradeCode permits parallel installation with 32-bit MSI * support for Visual Studio 2005 (VS8, CL1400) merge modules Open Issues: * 32-bit MSI installs kfwlogon.dll on AMD64 systems * 32-bit and 64-bit NetIDMgr.exe as startup. Need to decide which should be executed by default. Only one can run at a time. * Need to make sure that src/windows/build properly configures the site-local.wxi file for Visual Studio 2005 and platform. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19922 dc483132-0cff-0310-8789-dd5450dbe970
* 64-bit Windows gss.exe (gui version of gss-client.exe)Jeffrey Altman2007-09-052-3/+5
| | | | | | | | | | Now that krbcc64.lib exists we can build the gss.exe gss-api test client. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19921 dc483132-0cff-0310-8789-dd5450dbe970
* krb5_fcc_generate_new is non-functionalEzra Peisach2007-09-052-49/+104
| | | | | | | | | | | | | File locking was non-existant in this code and fccs chained list was not used at all. This resulted in an assertion failure when closing the cache. Code has been reorganized to parallel the code in krb5_fcc_resolve for easier maintenence. Commented out test in t_cc.c has been updated to actually test this code. ticket:new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19920 dc483132-0cff-0310-8789-dd5450dbe970