summaryrefslogtreecommitdiffstats
path: root/src/windows
Commit message (Collapse)AuthorAgeFilesLines
* The NIM error reporting functions (in src/windows/identity/kherr ) keepJeffrey Altman2008-07-231-1/+1
| | | | | | | | | | | | | | | | | | | | track of the the error message with the highest severity level that was reported for a specific error reporting context. However, if another error message of the same severity is reported, the error message being tracked will be updated to be the newly received error. The user will often only be notified of the error message that was tracked for a specific operation. Therefore, tracking the last message with the highest priority has the unfortunate side-effect of not reporting the cause of a failure. This patch changes the condition for updating the tracked error message to be the first message with the highest severity. ticket: 6047 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20573 dc483132-0cff-0310-8789-dd5450dbe970
* This patch modifies the NIM Kerberos v5 plug-in to use the Jeffrey Altman2008-07-234-8/+64
| | | | | | | | | | | | | krb5_get_error_message() function to look up the error string if the call to krb5_get_init_creds_password() fails. If the call to krb5_get_error_message() fails, the caller will failover to the previous method of looking up a suitable error message based on the error code. ticket: 5745 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20572 dc483132-0cff-0310-8789-dd5450dbe970
* Jeffrey Altman2008-07-232-0/+9
| | | | | | | | | | | | | | | | | | | The /src/windows/identity/plugins/common/dynimport.{c,h} files are used by the NIM Kerberos v5 plug-ins for run-time dynamic linking. They currently do not declare or import the following functions: krb5_get_error_message() krb5_free_error_message() krb5_clear_error_message() This patch adds declarations and definitions required for locating these functions. Relies on the addition of these functions to the prototype list in the Pismere loadfuncs-krb5.h. See ticket 6045. ticket: 6046 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20571 dc483132-0cff-0310-8789-dd5450dbe970
* cw_handle_header_msg():Jeffrey Altman2008-07-231-6/+2
| | | | | | | | | | | | | | | | The behavior of the HDN_ENDTRACK notification has changed slightly on Vista. HDM_GETITEMRECT, when used while handling HDN_ENDTRACK, returns the item extents that were there prior to the user starting the resizing operation. Earlier it would return the extents that resulted from the resizing operation. This resulted in a visual update problem on Windows Vista/2008 in the NIM Advanced View. ticket: 5605 tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20570 dc483132-0cff-0310-8789-dd5450dbe970
* Add kerberos iconAlexandra Ellwood2008-07-081-0/+0
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20501 dc483132-0cff-0310-8789-dd5450dbe970
* Detect if the Vista version of ntsecapi.h is presentKevin Koch2008-03-184-2/+42
| | | | | | | | | | TargetVersion: 1.7 Component: krb5-libs Ticket: 19569 tAGS: PULLUP Subj: Tweaks for 1.7 build on Windows. git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20277 dc483132-0cff-0310-8789-dd5450dbe970
* Changes to integrate the CCAPI build into the build structure, build the ↵Kevin Koch2008-02-191-8/+17
| | | | | | | | | | | | | | | | | | | | | | | test suite and fixes to random problems discovered along the way Since no platform other than windows builds CCAPI using the build system, some conditionalizing may be necessary when other platforms use the makefiles. src/Makefile.in: Add CPPFLAGS that seemed to be missing; run wconfig for ccapi/(lib, server, test). config/win-pre.in: DEBUGOPT /ZI doesn't seem to provide enough debugging information under VS2005; /Zi does. windows/build/bkw.pl: Fix -no<switch> so that -nonodebug will work. Otherwise, can't do debug build. Move Get/PutTspData out of dllmain; add tlsindex argument. Comment out some debug messages. TargetVersion: 1.7 Component: krb5-libs Ticket: 5594 Tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20229 dc483132-0cff-0310-8789-dd5450dbe970
* Actually pass the nmake arguments to nmakeKevin Koch2008-01-311-5/+5
| | | | | | | | | | TargetVersion: 1.7 Component: windows Ticket: new Subj: Build automation Tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20213 dc483132-0cff-0310-8789-dd5450dbe970
* Windows: avoid use of cygwin mkdir and rmdir commandsJeffrey Altman2008-01-232-4/+4
| | | | | | | | | | | | | | | Microsoft's nmake versions 8.x and 9.x prefer executables over internal shell commands. This is a change from previous versions. Cygwin's mkdir and rmdir commands do not have the same semantics as the cmd.exe shell versions. Change the definitions of MKDIR and RMDIR to use 'md' and 'rd' in order to avoid the use of the cygwin versions. ticket: new tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20211 dc483132-0cff-0310-8789-dd5450dbe970
* Update build instructions to indicate PATH ordering; add troubleshooting tip ↵Kevin Koch2008-01-231-9/+20
| | | | | | | | | | about nmake versions Target_Version: 1.7 Ticket: 5859 Tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20210 dc483132-0cff-0310-8789-dd5450dbe970
* KFW: BUG: KRB5CRED: Set identity data before sending notificationJeffrey Altman2007-12-121-1/+1
| | | | | | | | | | | Call tc_set_ident_data() before kcdb_credset_collect(). Make sure the identity data is set before the credentials change notification is broadcast. ticket: new component: windows tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20176 dc483132-0cff-0310-8789-dd5450dbe970
* KFW BUG: WIX: 64-bit installer attempts to uninstall 32-bit NSIS Jeffrey Altman2007-12-121-2/+3
| | | | | | | | | | | The 64-bit MSI must examine Win64 registry keys and not the 32-bit registry keys which is where the 32-bit NSIS installation will be detected. ticket: new component: windows tags: pullup git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20174 dc483132-0cff-0310-8789-dd5450dbe970
* The khm_show_main_window() function is no longer calledJeffrey Altman2007-11-141-7/+18
| | | | | | | | | | | | | | | | | | | at startup with khm_nCmdShow == SW_SHOWMINIMIZED in order to hide the main application by calling khm_hide_main_window(). Instead, the main application window is simply never shown. As a result, khm_show_main_window() needs to respond to khm_nCmdShow == SW_SHOWMINIMIZED not by hiding the window but by changing the khm_nCmdShow state to SW_SHOW and then calling ShowWindow(). This change will address the problem whereby "Show NIM Window" had to be triggered twice by the user when the process was started in a minimized state. ticket: 5842 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20164 dc483132-0cff-0310-8789-dd5450dbe970
* KFW: BUG: WIX: Beta value hard coded Jeffrey Altman2007-10-181-1/+1
| | | | | | | | | | | | | The beta variable value was inadvertantly committed as part of ticket 5820 (Revision 20117). The build script needs to export this value when appropriate. ticket: new component: windows tags: pullup target: 1.6.3 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20128 dc483132-0cff-0310-8789-dd5450dbe970
* There appears to be a bug either in the WiX engine or the Windows Installer 3.1.Jeffrey Altman2007-10-124-9/+24
| | | | | | | | | | | | | | | | | | | | | The "File" type on the Registry Search property is supposed to provide the full path name. Instead, we are being given just the directory as if it were being processed with the "Directory" type. We can avoid this for a REG_SZ value by using the "Raw" type because we are sure that the string is not going to begin with a '#' character. Because the full path was not being obtained for the UPGRADENSIS property, the Uninstall routine was unable to CreateProcess() the uninstall program. This commit also includes addition debugging in the NSIS Uninstall custom handler to report the path and the GetLastError() value when the uninstall fails. This will be logged in the msiexec log file and displayed in a MessageBox. ticket: 5820 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20119 dc483132-0cff-0310-8789-dd5450dbe970
* Set the Shortcut string to match the base product nameJeffrey Altman2007-10-121-1/+1
| | | | | | ticket: 5820 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20118 dc483132-0cff-0310-8789-dd5450dbe970
* KFW: BUG: WIX: Improve Usability of multiple architecture MSI installations, ↵Jeffrey Altman2007-10-126-29/+50
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | remove non-unique GUID component identifiers, and include Beta ID in the package name The WiX installation package suffered from several problems: * The Beta ID was not being included in the package name. Fixed this by swapping the priority of "Release" and "Beta". "Beta" is an official release that has a beta value. A non-release has a datestamp as part of the package name. * There were duplicate GUID values being used for registry components. This would prevent proper removal of the components on uninstall. * 64-bit Installers were being constructed with the 32-bit installer schema. This prevented side-by-side installation of the 64-bit and 32-bit versions. This also permitted 64-bit installers to be installed on 32-bit systems. * The 64-bit and 32-bit installers had the same package name. 64-bit and 32-bit are now identified in the package name. * 64-bit files were being installed to the WOW64 environment. ticket: new component: windows tags: pullup target_version: 1.6.3 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20117 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: New edit controls should be marked ES_AUTOHSCROLLJeffrey Altman2007-10-051-1/+1
| | | | | | | | | | | | | | | The EDIT controls used to accept input from the user must be set to support automatic horizontal scrolling. Otherwise, the number of input characters is arbitrarily restricted based upon the font selected by the user as part of the active Windows theme. Horizontal scrolling is enabled with the ES_AUTOHSCROLL flag during control construction. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20101 dc483132-0cff-0310-8789-dd5450dbe970
* KfW Build: add new installer build files to copyfiles.xmlKevin Koch2007-10-051-0/+3
| | | | | | | | | | Files were added to the installer build area. They also need to be added to the copylist, so that they are copied to the staging area, where the installer is built. Ticket: new Tags: pullup Target_Version: 1.6.3 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20099 dc483132-0cff-0310-8789-dd5450dbe970
* Process WM_CLOSE for the command-line option dialogJeffrey Altman2007-10-011-0/+8
| | | | | | | | | ticket: 5798 tags: pullup target_version: 1.6.3 component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20035 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: notification icon tooltip wrong stringJeffrey Altman2007-10-011-0/+2
| | | | | | | | | | | | | | | | | | | The Network Identity Manager notification icon can display a tooltip when the user hovers the mouse cursor over it. It is currently used to indicate the default identity (if one is found). However, when retrieving the name of the default identity, the size of the buffer was left unspecified. This patch specifies the correct buffer size. The function called with the incorrect buffer size was kcdb_identity_get_name(). That function does not write more than KCDB_IDENT_MAXCCH_NAME characters regardless of the size of the buffer specified, and the buffer that was passed in is allocated to be this size. No buffer overrun was present in the existing code, although the behavior was incorrect. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20034 dc483132-0cff-0310-8789-dd5450dbe970
* When Network Identity Manager starts, the credentials displayJeffrey Altman2007-10-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | enumerates known identities and displays them if necessary. However, as plug-ins load and the list of known identities, their properties and credentials change, the order of the displayed list will also change. The existing code does not deal well in respect to tracking the current selection when the list of identities and credentials change. This results in inconsistent behavior where the identity that was originally at the top of the list maintains its selection state while the identity at the top of the list after all the plug-ins have loaded will receive focus. This patch fixes this problem by explicitly setting focus and selection to the identity or credential at the current cursor location following a change in the credentials list. ticket: 5782 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20033 dc483132-0cff-0310-8789-dd5450dbe970
* The credentials display in Network Identity Manager colors theJeffrey Altman2007-10-011-14/+19
| | | | | | | | | | | | | | | | | background of identity headings based on the expiration state of the credentials that belong to the identity. This patch changes the behavior to color these headings based on the existence and expiration state of identity credentials. With this change, only identities that have valid identity credentials will appear in green. The same logic is used when drawing the menu items in the "Set default" sub-menu in the notification icon. ticket: 5783 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20032 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: notification icon state Jeffrey Altman2007-10-011-13/+28
| | | | | | | | | | | | | | | | Currently, the notification icon that is created by Network Identity Manager indicates the status of all the known credentials. If any credential belonging to any identity is expired or in a critical state, the icon will change color to indicate this. This patch changes the behavior to only indicate the status of credentials belonging to the default identity. The expiration state of credentials that do not belong to the default identity no longer affect the appearance of the notification icon. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20031 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: identity data corruptionJeffrey Altman2007-10-011-1/+1
| | | | | | | | | | | | | | The credentials display in Network Identity Manager uses a cached set of properties for each identity that has credentials. The existing code used the wrong field of the khui_credwnd_identity structure to store the credentials type name associated with an identity, resulting in a corrupt data structure. This patch fixes the code to use the correct field. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20030 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: View-Select columns Jeffrey Altman2007-10-011-1/+2
| | | | | | | | | | Change "View columns" to "Select columns" in the "View" menu of Network Identity Manager to be consistent with other Windows applications. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20029 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: leaking prompts in obtain new credentials dialogJeffrey Altman2007-10-011-0/+12
| | | | | | | | | | | | | | The Kerberos v5 plug-in for Network Identity Manager was not clearing the list of prompts properly when a user changes the active identity in the new credentials dialog. The stale prompts would be visible to the user if the newly selected identity is invalid or the new identity cannot be validated. This patch clears the prompts if there is an identity change. ticket: new git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20028 dc483132-0cff-0310-8789-dd5450dbe970
* add descriptions of credential flags, identity icons, and push-pinsJeffrey Altman2007-10-0124-173/+221
| | | | | | | | | | | | update screen shots add credits to Fermilabs and Stanford University. other changes for kfw 3.2.2 release. ticket: 5789 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20027 dc483132-0cff-0310-8789-dd5450dbe970
* fix the description of the notification icon status colorsJeffrey Altman2007-10-012-0/+0
| | | | | | ticket: 5789 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20026 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: deadlock in kmqJeffrey Altman2007-09-303-0/+19
| | | | | | | | | | | | Do not obtain a critical section that is already being held: "cs_kmq_types" Update the docs to indicate the additional restriction. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20025 dc483132-0cff-0310-8789-dd5450dbe970
* When there is no ImagePath value for a module it indicatesJeffrey Altman2007-09-301-1/+5
| | | | | | | | | | | | | that the module has not been installed. Do not report an error to the end user for uninstalled modules. This will only annoy the user and there is probably nothing the user can do about it. Perhaps the user uninstalled the module intentionally. The fact that there is still a HKCU key remaining is not an indication that the module is in use. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20023 dc483132-0cff-0310-8789-dd5450dbe970
* Remove Krb5Cred, Krb5Ident, and Krb4Cred default configuration data fromJeffrey Altman2007-09-302-9/+45
| | | | | | | | | | | | | | | the KMM Schema. Require that modules that are installed be properly installed. Add NIM Module Registry values to the NSIS installer. These values were already being set by the Wix installer. By removing the ImagePath default, unable to load module errors will not be generated when the module has not in fact been installed. ticket: 5753 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20022 dc483132-0cff-0310-8789-dd5450dbe970
* fix documentation typoJeffrey Altman2007-09-301-1/+1
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20021 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: disable warningJeffrey Altman2007-09-301-1/+4
| | | | | | | | | | Disable the potentially uninitialized variable warning for 'ri'. The variable cannot be used when uninitialized. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20020 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: PDF user documentation updates for KFW 3.2.2Jeffrey Altman2007-09-302-0/+0
| | | | | | | | | updates for NIM 1.3.1 / KFW 3.2.2 ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20019 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Provide keyboard accelerator Jeffrey Altman2007-09-291-1/+1
| | | | | | | | | | In the Advanced mode of the Obtain New Credentials dialog the keyboard accelerator was missing. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20018 dc483132-0cff-0310-8789-dd5450dbe970
* Fix typoJeffrey Altman2007-09-291-0/+0
| | | | | | ticket: 5787 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20017 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: APP: Spell CheckJeffrey Altman2007-09-292-34/+34
| | | | | | | | | Correct typos. Make use of "plug-in" vs "plugin" consistent. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20016 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: FEATURE: APP: Notification Icon Tooltip Jeffrey Altman2007-09-273-34/+66
| | | | | | | | | | | | | | The Network Identity Manager notification icon can have a tooltip associated with it. The tooltip will be displayed to the user if she hovers the mouse cursor over the notification icon. Currently, the tooltip is used to indicate the current status of Network Identity Manager. This patch adds the name of the default identity to the tooltip. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19985 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: LIB: optimize khui_find_action()Jeffrey Altman2007-09-271-7/+9
| | | | | | | | | | | | In Network Identity Manager, when locating the action object corresponding to an action identifier using khui_find_action(), don't search through the list of standard actions if we already know that the object we are searching for is a custom action. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19984 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "Set default" sub menu to the Network Identity ManagerJeffrey Altman2007-09-2712-59/+317
| | | | | | | | | | | | | notification icon context menu. The submenu will display a list of identities that the user can select as the default identity. Each identity that is displayed in the sub menu will be colored the same way it is colored in the basic view to provide a hint as to the state of the credentials belonging to the identity. ticket: 5724 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19983 dc483132-0cff-0310-8789-dd5450dbe970
* Add a "View all identities" option to the view menu of NetworkJeffrey Altman2007-09-279-7/+77
| | | | | | | | | | | | | Identity Manager. This option will be toggled when selected. If enabled, all the known identities will be displayed in any credentials view which uses the identity of credentials as the primary group-by field. The setting of this option is persistent. ticket: 5719 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19982 dc483132-0cff-0310-8789-dd5450dbe970
* Document use of KRB5_CCH_CCNAME for ccache name lengthJeffrey Altman2007-09-251-4/+4
| | | | | | ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19978 dc483132-0cff-0310-8789-dd5450dbe970
* change all MAX_PATH ccname buffer lengths to KRB5_CCH_CCNAME and Jeffrey Altman2007-09-251-8/+8
| | | | | | | | document the use of KRB5_CCH_CCNAME. ticket: 5772 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19977 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KMM: miscellaneous fixesJeffrey Altman2007-09-253-13/+17
| | | | | | | | | | | | | | | | | | | kmm_reg.c: Allocate enough memory to hold the entire PluginList multi-string plus an extra NUL if the registry value was not properly terminated. kmm_registrar.c: Do not record an error loading a module if there was no configuration for it. kmmmain.c: Avoid a race condition by sending the thread quit message instead of posting it. Do so outside of the critical section to avoid a deadlock. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19976 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: KRB5: cleanup krb5funcsJeffrey Altman2007-09-251-2/+3
| | | | | | | | | | | | | | | | (1) remove an extraneous backslash from the generated FILE: ccache name. GetTempPath() always returns paths terminated with a backslash. (2) increase the max ccache name length to KRB5_CCH_CCNAME from MAX_PATH. These changes have dependencies on revisions 19891 and 19897. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19975 dc483132-0cff-0310-8789-dd5450dbe970
* More consolidation of the computation of the default ccache nameJeffrey Altman2007-09-251-29/+2
| | | | | | ticket: 5691 git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19974 dc483132-0cff-0310-8789-dd5450dbe970
* Set svn:eol-style on a bunch of text-looking files that didn't have itKen Raeburn2007-09-24115-11761/+11761
| | | | git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19972 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: Restore Copyright removed in revision 19855Jeffrey Altman2007-09-241-0/+1
| | | | | | | | | Restore MIT Copyright removed in revision 19855. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19968 dc483132-0cff-0310-8789-dd5450dbe970
* NIM: BUG: khm_krb5_initialize() failed to return error codeJeffrey Altman2007-09-241-4/+4
| | | | | | | | | | | | | | | | khm_krb5_initialize() is called in the krb5cred.dll and krb4cred.dll credential providers in order to ensure that the caller has references to a valid krb5_context and a valid krb5_ccache. If the krb5_cc_resolve() call failed, the error code was not being returned to the caller. Instead, success was returned which in turn would result in the caller believing the NULL krb5_ccache pointer was in fact valid. This fix resolves Microsoft's WER Event ID 432405961. ticket: new component: windows git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@19967 dc483132-0cff-0310-8789-dd5450dbe970