summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Avoid a crash when attempting to change passwordBenjamin Kaduk2012-08-291-1/+1
| | | | | | | | | | | | | In some cases we could keep stack garbage in a local pointer variable until the cleanup at the end of the function wherein krb5_free_context() would choke on the invalid non-NULL value. Initialize to zero to avoid the issue (should be written as NULL but stick to the prevailing style). ticket: 7329 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Rename old krb5.ini files awayBenjamin Kaduk2012-08-292-1/+15
| | | | | | | | | | | | | | | | | We want to always use a new krb5.ini (and our search order guarantees that we will), but users might be confused if there is still a file named krb5.ini in the old location which is now non-functional. However, it is rude to unconditionally delete the old file which may potentially be the only copy a user has of their local changes. Instead, rename the old file to a non-functioning name that indicates it is no longer being used, so that it may be consulted if needed. Only attempt the rename if we found an existing krb5.ini, and ignore errors since this is not a critical part of the installation. ticket: 7328 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Add domain_realm mappings to the athena krb5.iniKevin Wasserman2012-08-291-0/+8
| | | | | | | | | | | | | | These seem to be the only bits from the krb5.ini shipped with older versions of KfW that remain useful. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> [kaduk@mit.edu: add motivation to commit message] ticket: 7327 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Fix renew_until check for auto-renewalKevin Wasserman2012-08-291-1/+1
| | | | | | | | | | | | | | | | This was completely wrong, but only caused a severe problem on 64 bit builds. On 32 bit builds the result was effectively always 'success', so it would always attempt to renew even if there was not sufficient time left in the renewable lifetime. This did not have much observable adverse effect. But on 64 bit builds it always failed and so never attempted renewal. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7326 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Fix warning caption "Leash"->"MIT Kerberos"Kevin Wasserman2012-08-291-1/+1
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7325 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Always install krb5.ini in KfW 4.0 installerKevin Wasserman2012-08-291-1/+0
| | | | | | | | | | | | | | Pre-existing krb5.ini files from old kfw versions will be overridden due to the new search path, but not removed. This is the desired behavior since old krb5.ini files are far more likely to cause problems than to contain useful data. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7324 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Put athena-specific krb5.ini in athena subdirKevin Wasserman2012-08-294-16/+9
| | | | | | | | | | | | | The installer only picks it up if MIT_INTERNAL is defined in the environment; otherwise it uses the now-empty krb5.ini in the base directory. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7323 (new) queue: kfw target_version: 1.10.4 tags: pullup
* CCAPI client rpc fixesKevin Wasserman2012-08-294-24/+24
| | | | | | | | | | | | | | | | On Windows XP, cci_os_ipc_thread_init() causes additional threads to be spawned immediately, which results in a vicious cycle until Windows resources are exhausted. Instead, defer thread_init() until it is really needed. Also, use the MSDN-recommended defaults for RPC calls instead of random constants. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7322 (new) target_version: 1.10.4 tags: pullup
* Handle missing autocomplete object gracefullyKevin Wasserman2012-08-291-14/+15
| | | | | | | | | | | Don't crash if we can't create a CLSID_AutoComplete instance. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7321 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Add both x86 and x64 msm's to x64 installerKevin Wasserman2012-08-292-15/+30
| | | | | | | | | | | Since we have x86 dlls, we need the x86 msm's. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7320 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Use env to determine config in installer buildKevin Wasserman2012-08-292-5/+8
| | | | | | | | | | | | Use NODEBUG and DEBUG_SYMBOL from the environment to determine whether or not to define Debug and DebugSyms for the installer build. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7319 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Use release MFC lib for NODEBUG buildsKevin Wasserman2012-08-291-0/+4
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7318 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Don't require pdbs for make installKevin Wasserman2012-08-291-20/+20
| | | | | | | | | | | | When NODEBUG is defined and DEBUG_SYMBOL is not, no pdbs are generated. This should not cause make install to fail. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7316 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Add MIT krb5.ini to wix install directoryKevin Wasserman2012-08-291-0/+3
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7315 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Fix installer UI field sizesKevin Wasserman2012-08-291-12/+12
| | | | | | | | | | | | Increase title control height to make all text visible. Adjust position of description controls accordingly. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7314 (new) queue: kfw target_version: 1.10.4 tags:pullup
* Fix ribbon label hotkeysKevin Wasserman2012-08-291-1/+1
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7311 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Fix menu text change breakageKevin Wasserman2012-08-291-5/+0
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7310 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Help -- remove principal drop-down refsKevin Wasserman2012-08-288-21/+18
| | | | | | | | | | | Also a couple of minor fixups. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7309 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Disable import/export buttons and checkboxKevin Wasserman2012-08-281-1/+1
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7308 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Update kfw installer OS version checksKevin Wasserman2012-08-282-2/+6
| | | | | | | | | | | Require XP SP3 or Vista SP2 or Windows 7 or Server 2003 or Server 2008 Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7307 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Call CWinAppEx::InitInstance()Kevin Wasserman2012-08-281-0/+3
| | | | | | | | | | | | | Without this, AfxGlobalsAddRef() is never called, so AfxGlobalsRelease() does nothing, causing many leaks and a crash on exit in GdiplusShutdown() on Vista. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7306 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Remove unused leashdll functionsKevin Wasserman2012-08-282-433/+0
| | | | | | | | | | | | | | | -not_an_API_LeashKRB5GetTickets -not_an_API_LeashKRB5FreeTickets and supporting routines. Also remove the unused support routine one_addr. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> [kaduk@mit.edu: adjust commit message] ticket: 7305 (new) queue: kfw target_version: 1.10.4 tags: pullup
* 'Destroy tickets on exit' destroys all ticketsKevin Wasserman2012-08-281-12/+7
| | | | | | | | | | | Previously destroyed only default ccache and used obsolete functions. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7304 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Use cc_user_set_default_name to 'make default'Kevin Wasserman2012-08-281-0/+8
| | | | | | | | | | | | | | In addition to calling krb5_cc_switch(), use krb5int_cc_user_set_default_name() in CLeashView::OnMakeDefault() to set the default ccache for all processes for the current user. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7303 (new) queue: kfw subject: 'Make default' should apply to all processes of the user target_version: 1.10.4 tags: pullup
* Minor 'Get Tickets' dialog fixesKevin Wasserman2012-08-282-4/+3
| | | | | | | | | | | | | -Move 'Remember this principal' and keep visible even when 'advanced' options are hidden. -Increase size of 'Forwardable and Proxiable' checkbox. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7301 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Help updates for kfw 4.0Kevin Wasserman2012-08-2887-12/+5085
| | | | | | | | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> [kaduk@mit.edu: Squash commits, a couple of grammar fixes, and also turn a few instances of "Leash" into "MIT Kerberos". Trim trailing whitespace and other whitespace tweaks to pass the commit hooks.] ticket: 7300 (new) queue: kfw target_version: 1.10.4 tags: pullup Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com>
* Reduce 'get tickets' dialog heightKevin Wasserman2012-08-271-1/+1
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7299 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Add 'Remember this principal' checkboxKevin Wasserman2012-08-273-1/+7
| | | | | | | | | | | Added to the 'Get Tickets' dialog. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7298 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Update kfw change password dialogKevin Wasserman2012-08-273-174/+91
| | | | | | | | | | | Use combined username/realm principal edit control. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7297 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW rename lacFoo -> Leash_pec_Kevin Wasserman2012-08-272-11/+11
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7294 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW make 64-bit MSI include 32-bit dllsKevin Wasserman2012-08-273-37/+74
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7293 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Rename "Leash" to "MIT Kerberos"Kevin Wasserman2012-08-277-19/+20
| | | | | | | | | | | In the executable name and many GUI elements. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7292 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW GUI -- clean up 'About' dialogKevin Wasserman2012-08-273-9/+37
| | | | | | | | | | | | By default, hide the debug list of loaded modules; change LeashView.cpp and recompile to get the list. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7291 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW update copyright date (2012) for all modulesKevin Wasserman2012-08-271-1/+1
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7290 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW WiX installer update copyright noticeKevin Wasserman2012-08-271-1/+1
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7289 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Remove copyright/version from Get Tickets dialogKevin Wasserman2012-08-272-158/+0
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7288 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW GUI -- add 'Options' categoryKevin Wasserman2012-08-271-1/+1
| | | | | | | | | | | | Move 'View' and 'Options' panels from Home to Options category. Rename to 'View Options' and 'Ticket Options' respectively. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7287 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Use bold for entire row for default principalKevin Wasserman2012-08-272-32/+46
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7286 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Rename 'Get Ticket' to 'MIT Kerberos: Get Ticket'Kevin Wasserman2012-08-272-4/+4
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7284 queue: kfw target_version: 1.10.4 tags: pullup
* KfW GUI -- abbreviate durationsKevin Wasserman2012-08-241-14/+4
| | | | | | | | | | | Map days -> d; hours -> h; minutes -> m Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7285 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Change 'Get Ticket' to 'MIT Kerberos: Get Ticket'Kevin Wasserman2012-08-242-7/+7
| | | | | | | | | | | Also improve string copy safety. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7284 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Rename and move 'Clear Principal History'Kevin Wasserman2012-08-241-2/+2
| | | | | | | | | | | Move it closer to the Principal edit box and rename to 'Clear History' Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7283 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Merge forwardable/proxiable in Get Tickets dialogKevin Wasserman2012-08-242-6/+4
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7282 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Update kfw ribbon button graphicsKevin Wasserman2012-08-241-1/+1
| | | | | | | | | | | Integrate bmp's from ui team. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7281 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW GUI -- show ticket flagsKevin Wasserman2012-08-241-1/+46
| | | | | | | | | Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7280 (new) queue: kfw target_version: 1.10.4 tags: pullup
* KfW GUI -- update expand/collapse icon renderingKevin Wasserman2012-08-241-10/+23
| | | | | | | | | Use DrawThemeBackground() to draw the icons from the explorer treeview. ticket: 7279 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Fix leashdll code to search for existing ticketsKevin Wasserman2012-08-241-275/+120
| | | | | | | | | | | | | When we have a desired principal, search the entire credential cache collection for existing tickets for that principal before using a prompter. If no principal is specified, check only the default cache. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7278 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Use file mapping to marshall message dataKevin Wasserman2012-08-242-49/+126
| | | | | | | | | | | | | GlobalAlloc() is no longer supported for this purpose. Also split out leash message marshalling code into a separate function acquire_tkt_send_message_leash and improve string copy safety. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7276 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Set kfw GUI read-only princ flag when appropriateKevin Wasserman2012-08-241-0/+3
| | | | | | | | | | | | | When receiving a request to obtain tickets (from another process), if a particular principal is requested, set the read-only flag to prevent the user from changing the principal. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7275 (new) queue: kfw target_version: 1.10.4 tags: pullup
* Add 'read-only principal' flagKevin Wasserman2012-08-242-18/+20
| | | | | | | | | | | | | Reserve the high-order 16 bits of dlgtype for flags. Add DLGFLAG_READONLY_PRINC. When specified, the get tickets dialog does not allow the user to change the principal. Signed-off-by: Kevin Wasserman <kevin.wasserman@painless-security.com> ticket: 7274 (new) queue: kfw target_version: 1.10.4 tags: pullup