diff options
| author | Greg Hudson <ghudson@mit.edu> | 2013-03-15 01:57:40 -0400 |
|---|---|---|
| committer | Greg Hudson <ghudson@mit.edu> | 2013-03-15 01:57:40 -0400 |
| commit | 525eafc83a0fbe8f215b7749b5774d54468a19d1 (patch) | |
| tree | b4cbeecffb898f61dad52430601139171f978bd1 /src/lib/krb5 | |
| parent | 233e97338784196ac610aaaffc74d4e7ba03ca9c (diff) | |
| download | krb5-525eafc83a0fbe8f215b7749b5774d54468a19d1.tar.gz krb5-525eafc83a0fbe8f215b7749b5774d54468a19d1.tar.xz krb5-525eafc83a0fbe8f215b7749b5774d54468a19d1.zip | |
Fix use-before-init in two test programs
If krb5_init_context fails, use a null context for getting the error
message, not a context we haven't yet initialized. Observed by David
Benjamin <davidben@mit.edu> using clang.
Diffstat (limited to 'src/lib/krb5')
| -rw-r--r-- | src/lib/krb5/krb/t_cc_config.c | 2 | ||||
| -rw-r--r-- | src/lib/krb5/krb/t_in_ccache.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/src/lib/krb5/krb/t_cc_config.c b/src/lib/krb5/krb/t_cc_config.c index 3750a59ed..04e7283d2 100644 --- a/src/lib/krb5/krb/t_cc_config.c +++ b/src/lib/krb5/krb/t_cc_config.c @@ -117,7 +117,7 @@ main(int argc, char **argv) int c; unsigned int i; - bail_on_err(context, "Error initializing Kerberos library", + bail_on_err(NULL, "Error initializing Kerberos library", krb5_init_context(&context)); bail_on_err(context, "Error getting location of default ccache", krb5_cc_default(context, &ccache)); diff --git a/src/lib/krb5/krb/t_in_ccache.c b/src/lib/krb5/krb/t_in_ccache.c index c73a04337..30b7f281a 100644 --- a/src/lib/krb5/krb/t_in_ccache.c +++ b/src/lib/krb5/krb/t_in_ccache.c @@ -95,7 +95,7 @@ main(int argc, char **argv) user = argv[optind]; password = argv[optind + 1]; - bail_on_err(ctx, "Error initializing Kerberos", krb5_init_context(&ctx)); + bail_on_err(NULL, "Error initializing Kerberos", krb5_init_context(&ctx)); bail_on_err(ctx, "Error allocating space for get_init_creds options", krb5_get_init_creds_opt_alloc(ctx, &opt)); if (in_ccname != NULL) { |