krb5.git/src/lib, branch proxymech MIT Kerberos patches Fix import_sec_context with interposers 2013-03-24T05:48:51+00:00 Simo Sorce simo@redhat.com 2013-03-16T19:23:03+00:00 36c76aa3c625afc9291b9e1df071db51ccf37dab The code was correctly selecting the mechanism to execute, but it was improperly setting the mechanism type of the internal context when the selected mechanism was that of an interposer and vice versa. When an interposer is involved the internal context is that of the interposer, so the mechanism type of the context needs to be the interposer oid. Conversely, when an interposer re-enters gssapi and presents a token with a special oid, the mechanism called is the real mechanism, and the context returned is a real mechanism context. In this case the mechanism type of the context needs to be that of the real mechanism. ticket: 7592 target_version: 1.11.2 tags: pullup 
The code was correctly selecting the mechanism to execute, but it was
improperly setting the mechanism type of the internal context when the
selected mechanism was that of an interposer and vice versa.

When an interposer is involved the internal context is that of the
interposer, so the mechanism type of the context needs to be the
interposer oid.  Conversely, when an interposer re-enters gssapi and
presents a token with a special oid, the mechanism called is the real
mechanism, and the context returned is a real mechanism context.  In
this case the mechanism type of the context needs to be that of the
real mechanism.

ticket: 7592
target_version: 1.11.2
tags: pullup
make depend 2013-03-24T05:30:33+00:00 Greg Hudson ghudson@mit.edu 2013-03-24T05:30:33+00:00 24c8bacbccc854dc30fd6baee49cdd2bf2557e47 






Move a bunch of stuff out of k5-int.h
2013-03-24T05:28:13+00:00

Greg Hudson
ghudson@mit.edu

2013-03-24T05:28:13+00:00

6c8fed1bb850b92d471b0741a452bb56354fc0e9

Move internal declarations from k5-int.h to more localized headers
(like int-proto.h) where appropriate.  Rename many symbols whose
prototypes were moved to use the k5_ prefix instead of krb5int_.
Remove some unused declarations or move them to the single source file
they were needed in.  Remove krb5_creds_compare since it isn't used
any more.





Move internal declarations from k5-int.h to more localized headers
(like int-proto.h) where appropriate.  Rename many symbols whose
prototypes were moved to use the k5_ prefix instead of krb5int_.
Remove some unused declarations or move them to the single source file
they were needed in.  Remove krb5_creds_compare since it isn't used
any more.







Get rid of krb5_{get,free}_krbhst
2013-03-22T20:00:48+00:00

Greg Hudson
ghudson@mit.edu

2013-03-22T20:00:48+00:00

81fde7e475b02986c1aff88766cc48882004d5dc

These functions were always internal.  They haven't been used since
v5passwdd was eliminated in krb5 1.4.





These functions were always internal.  They haven't been used since
v5passwdd was eliminated in krb5 1.4.







Get rid of osconfig.c
2013-03-22T18:39:18+00:00

Greg Hudson
ghudson@mit.edu

2013-03-22T16:59:48+00:00

ee2044f38503edd2fdb8df9f3398784f747910fb

These variables were marked as internal in 1996.  Two are unused and
the other is easily replaced with the macro it is initialized from.





These variables were marked as internal in 1996.  Two are unused and
the other is easily replaced with the macro it is initialized from.







Eliminate unused variables
2013-03-15T06:22:42+00:00

Greg Hudson
ghudson@mit.edu

2013-03-15T06:22:42+00:00

5bd6230bb2474bbed754c6d95eeee9c47c461d2c












Fix argument type in kg_unseal_v1
2013-03-15T06:16:39+00:00

Greg Hudson
ghudson@mit.edu

2013-03-15T06:16:39+00:00

54d91d0666ac7539b0a8fe26fc4cb795ade1a042

The caller of kg_unseal_v1 passes a gss_qop_t * for the qop_state
parameter, so make it use that type instead of an int *.  Noted by
David Benjamin <davidben@mit.edu>.





The caller of kg_unseal_v1 passes a gss_qop_t * for the qop_state
parameter, so make it use that type instead of an int *.  Noted by
David Benjamin <davidben@mit.edu>.







Fix condition with empty body
2013-03-15T06:01:51+00:00

David Benjamin
davidben@mit.edu

2013-03-13T05:08:01+00:00

18796a2eb6c05706c6635453b3e425955aab93f4

Found by clang's warnings.

ticket: 7591 (new)
target_version: 1.11.2
tags: pullup





Found by clang's warnings.

ticket: 7591 (new)
target_version: 1.11.2
tags: pullup







Allocate space for NUL byte in test code
2013-03-15T06:00:53+00:00

David Benjamin
davidben@mit.edu

2013-03-13T05:07:32+00:00

fae4c736021399750833e24316e19a82f62e21b2

Caught by ASan.





Caught by ASan.







Fix use-before-init in two test programs
2013-03-15T05:57:40+00:00

Greg Hudson
ghudson@mit.edu

2013-03-15T05:57:40+00:00

525eafc83a0fbe8f215b7749b5774d54468a19d1

If krb5_init_context fails, use a null context for getting the error
message, not a context we haven't yet initialized.  Observed by David
Benjamin <davidben@mit.edu> using clang.





If krb5_init_context fails, use a null context for getting the error
message, not a context we haven't yet initialized.  Observed by David
Benjamin <davidben@mit.edu> using clang.