From 08baaa465b837ec6a46f27afbdf30102dc7dec0b Mon Sep 17 00:00:00 2001
From: Dolph Mathews <dolph.mathews@gmail.com>
Date: Fri, 11 Jan 2013 15:04:39 -0600
Subject: Why .pop()'ing urls first is important

The following code review made me realize that this really needed to be
commented: https://review.openstack.org/#/c/19431/

Change-Id: I70c1e640db716f6bc0a01bf8fdf8145a8ea730ac
---
 keystone/catalog/controllers.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/keystone/catalog/controllers.py b/keystone/catalog/controllers.py
index 8dddf469..b0b2d934 100644
--- a/keystone/catalog/controllers.py
+++ b/keystone/catalog/controllers.py
@@ -86,8 +86,10 @@ class Endpoint(controller.V2Controller):
 
         legacy_endpoint_ref = endpoint.copy()
 
+        # pop all urls off the endpoint so we don't persist them more than once
         urls = dict((i, endpoint.pop('%surl' % i)) for i in INTERFACES
                     if endpoint.get('%surl' % i) is not None)
+
         legacy_endpoint_id = uuid.uuid4().hex
         for interface, url in urls.iteritems():
             endpoint_ref = endpoint.copy()
-- 
cgit