diff options
| author | Wu Wenxiang <wu.wenxiang@99cloud.net> | 2013-06-16 04:18:05 +0800 |
|---|---|---|
| committer | Wu Wenxiang <wu.wenxiang@99cloud.net> | 2013-06-16 05:23:50 +0800 |
| commit | 76e3183ead6ac52fc744f51313bc0fd3b5f4d610 (patch) | |
| tree | 84f838d62cab03f99cf1b405002f341682292b94 /tests/test_backend_ldap.py | |
| parent | 3c687d17016cb8efcfdce2de0d2f923121917fcb (diff) | |
| download | keystone-76e3183ead6ac52fc744f51313bc0fd3b5f4d610.tar.gz keystone-76e3183ead6ac52fc744f51313bc0fd3b5f4d610.tar.xz keystone-76e3183ead6ac52fc744f51313bc0fd3b5f4d610.zip | |
Http 400 when project enabled is not a boolean
Having enabled="true" in json data when updating tenant will produce 500
When updating a project, no type check was performed on the enabled
attribute. Therefore, if enabled value in JSON/XML is not a boolean but
a string, keystone responds with an incorrect Http 500 error code and
the stacktrace.
The change introduces a type validation of the enabled attribute at
identity manager. If the type is not a boolean, keystone now returns an
appropriate Http 400 error code with a message pointing a bad format for
the attribute.
Test cases have been added to file test_backend and test_content_types
for testing the case when enabled attribute is a string or int when
updating project.
Fixes bug #1191384
Change-Id: I86dd7e71d4bac1e3fd6fcabaa1a2136a47722e5f
Diffstat (limited to 'tests/test_backend_ldap.py')
| -rw-r--r-- | tests/test_backend_ldap.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/test_backend_ldap.py b/tests/test_backend_ldap.py index 60b9f4ba..ecdc7465 100644 --- a/tests/test_backend_ldap.py +++ b/tests/test_backend_ldap.py @@ -113,7 +113,7 @@ class LDAPIdentity(test.TestCase, test_backend.IdentityTests): tenant_ref = self.identity_api.get_project('fake1') self.assertEqual(tenant_ref['id'], 'fake1') - tenant['enabled'] = 'False' + tenant['enabled'] = False self.identity_api.update_project('fake1', tenant) self.identity_api.delete_project('fake1') @@ -133,7 +133,7 @@ class LDAPIdentity(test.TestCase, test_backend.IdentityTests): 'fake1', tenant) - self.tenant_bar['enabled'] = 'False' + self.tenant_bar['enabled'] = False self.assertRaises(exception.ForbiddenAction, self.identity_api.update_project, self.tenant_bar['id'], |