diff options
| author | Morgan Fainberg <m@metacloud.com> | 2013-07-28 16:16:13 -0700 |
|---|---|---|
| committer | Morgan Fainberg <m@metacloud.com> | 2013-08-01 14:36:18 -0700 |
| commit | 5519e1ba16f59f302cda6e8db8f5423eed376ddf (patch) | |
| tree | f1f34ab8e87d480ae743f35a49f62128ac84dbf8 /keystone/contrib/ec2/core.py | |
| parent | 97a5b49d96f4ed31c8fa9795d835480d58da82cd (diff) | |
| download | keystone-5519e1ba16f59f302cda6e8db8f5423eed376ddf.tar.gz keystone-5519e1ba16f59f302cda6e8db8f5423eed376ddf.tar.xz keystone-5519e1ba16f59f302cda6e8db8f5423eed376ddf.zip | |
Remove kwargs from manager calls where not needed.
This patch removes the use of kwargs from manager calls where not
required. Dogpile.cache (the targeted caching library) does not
support kwargs out of the box with its cache-key-generator. This
change allows us to support the default cache-key-generator; while
it is possible to create a new cache-key-generator function, there
are many possible edge-cases to deal with when making cache
invalidation calls (ensuring the arguments are the same) as well as
possible performance implications (depending on the depth of method
introspection needed to determine how to invalidate the cache).
As an added bonus, this change brings the code touched more in-line
with the rest of keystone where most manager/driver calls do not
use kwargs unless absolutley required.
blueprint: caching-layer-for-driver-calls
Change-Id: I035c976314fb48f657661f681f7c1760d3c547a6
Diffstat (limited to 'keystone/contrib/ec2/core.py')
| -rw-r--r-- | keystone/contrib/ec2/core.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/keystone/contrib/ec2/core.py b/keystone/contrib/ec2/core.py index adba7e74..8f72e431 100644 --- a/keystone/contrib/ec2/core.py +++ b/keystone/contrib/ec2/core.py @@ -188,9 +188,7 @@ class Ec2Controller(controller.V2Controller): for role_id in roles] catalog_ref = self.catalog_api.get_catalog( - user_id=user_ref['id'], - tenant_id=tenant_ref['id'], - metadata=metadata_ref) + user_ref['id'], tenant_ref['id'], metadata_ref) auth_token_data = dict(user=user_ref, tenant=tenant_ref, |