summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMonty Taylor <mordred@inaugust.com>2012-01-31 13:40:29 -0500
committerMonty Taylor <mordred@inaugust.com>2012-01-31 14:16:03 -0500
commitfc3de2491d15f446d6223ff494bbeaef06fda8ac (patch)
tree5fe756ce6b3883611602095e756720db67a6a3c9
parentcf3f671a050f5cb5a2acc8c8c4b0b6b7a3a0d892 (diff)
downloadkeystone-fc3de2491d15f446d6223ff494bbeaef06fda8ac.tar.gz
keystone-fc3de2491d15f446d6223ff494bbeaef06fda8ac.tar.xz
keystone-fc3de2491d15f446d6223ff494bbeaef06fda8ac.zip
Use gerrit instead of github
When we run gating tests in jenkins, any access of network resources is a potential source of false-negative on the test due to intermittent service failures on systems that are out of our control. We observe that this is actually quite frequent when things want to access PyPI or github. With pypi, we pre-create virtualenvs and cache the eggs so that an individual test run doesn't fail due to pypi not responding. For repos, if at all possible, we direct them all at the gerrit instance, because since gerrit is driving the test run in the first place, it's indicative of a much larger problem if jenkins can't talk to it - and it's one that we can fix if it does come up. Change-Id: I9f54133f7f2025d15a9d0b270d2466438cbc6dd5
-rw-r--r--tests/test_keystoneclient.py3
-rw-r--r--tests/test_legacy_compat.py8
-rw-r--r--tests/test_novaclient_compat.py3
3 files changed, 8 insertions, 6 deletions
diff --git a/tests/test_keystoneclient.py b/tests/test_keystoneclient.py
index 9766108a..d7748649 100644
--- a/tests/test_keystoneclient.py
+++ b/tests/test_keystoneclient.py
@@ -7,7 +7,8 @@ from keystone import test
import default_fixtures
CONF = config.CONF
-KEYSTONECLIENT_REPO = 'git://github.com/openstack/python-keystoneclient.git'
+OPENSTACK_REPO = 'https://review.openstack.org/p/openstack'
+KEYSTONECLIENT_REPO = '%s/python-keystoneclient.git' % OPENSTACK_REPO
class CompatTestCase(test.TestCase):
diff --git a/tests/test_legacy_compat.py b/tests/test_legacy_compat.py
index ff6b7fdb..e9d9ebc0 100644
--- a/tests/test_legacy_compat.py
+++ b/tests/test_legacy_compat.py
@@ -13,11 +13,11 @@ from keystone.common import utils
CONF = config.CONF
+OPENSTACK_REPO = 'https://review.openstack.org/p/openstack/'
-IDENTITY_API_REPO = 'git://github.com/openstack/identity-api.git'
-KEYSTONE_REPO = 'git://github.com/openstack/keystone.git'
-NOVACLIENT_REPO = 'git://github.com/rackspace/python-novaclient.git'
-
+IDENTITY_API_REPO = '%s/identity-api.git' % OPENSTACK_REPO
+KEYSTONE_REPO = '%s/keystone.git' % OPENSTACK_REPO
+NOVACLIENT_REPO = '%s/python-novaclient.git' % OPENSTACK_REPO
IDENTITY_SAMPLE_DIR = 'openstack-identity-api/src/docbkx/samples'
KEYSTONE_SAMPLE_DIR = 'keystone/content/common/samples'
diff --git a/tests/test_novaclient_compat.py b/tests/test_novaclient_compat.py
index b4f6dc79..5578e4f7 100644
--- a/tests/test_novaclient_compat.py
+++ b/tests/test_novaclient_compat.py
@@ -12,7 +12,8 @@ import default_fixtures
CONF = config.CONF
-NOVACLIENT_REPO = 'git://github.com/openstack/python-novaclient.git'
+OPENSTACK_REPO = 'https://review.openstack.org/p/openstack'
+NOVACLIENT_REPO = '%s/python-novaclient.git' % OPENSTACK_REPO
class CompatTestCase(test.TestCase):