diff options
author | Ionuț Arțăriși <iartarisi@suse.cz> | 2013-02-04 16:11:33 +0100 |
---|---|---|
committer | Ionuț Arțăriși <iartarisi@suse.cz> | 2013-02-04 16:11:33 +0100 |
commit | 8a7812602dc108faaa65b517b51b2dc6db57bd4c (patch) | |
tree | 3d81cab4f81a32f3739dd0e39da2aceb4ad15d89 | |
parent | 4722c84fb90c51fb5810ad7b46c48230ecee1a6c (diff) | |
download | keystone-8a7812602dc108faaa65b517b51b2dc6db57bd4c.tar.gz keystone-8a7812602dc108faaa65b517b51b2dc6db57bd4c.tar.xz keystone-8a7812602dc108faaa65b517b51b2dc6db57bd4c.zip |
don't create a new, copied list in get_project_users
also replace other for loops with list iterations
Change-Id: I3d6dc40f108b6f235a6c6d43a867c91845f442cd
-rw-r--r-- | keystone/identity/backends/ldap/core.py | 18 |
1 files changed, 4 insertions, 14 deletions
diff --git a/keystone/identity/backends/ldap/core.py b/keystone/identity/backends/ldap/core.py index ca2177b7..5ed14386 100644 --- a/keystone/identity/backends/ldap/core.py +++ b/keystone/identity/backends/ldap/core.py @@ -156,27 +156,17 @@ class Identity(identity.Driver): def get_projects_for_user(self, user_id): self.get_user(user_id) - tenant_list = [] - for tenant in self.project.get_user_projects(user_id): - tenant_list.append(tenant['id']) - return tenant_list + return [p['id'] for p in self.project.get_user_projects(user_id)] def get_project_users(self, tenant_id): self.get_project(tenant_id) - user_list = [] - for user in self.project.get_users(tenant_id): - user_list.append(user) - return user_list + return self.project.get_users(tenant_id) def get_roles_for_user_and_project(self, user_id, tenant_id): self.get_user(user_id) self.get_project(tenant_id) - assignments = self.role.get_role_assignments(tenant_id) - roles = [] - for assignment in assignments: - if assignment.user_id == user_id: - roles.append(assignment.role_id) - return roles + return [a.role_id for a in self.role.get_role_assignments(tenant_id) + if a.user_id == user_id] def add_role_to_user_and_project(self, user_id, tenant_id, role_id): self.get_user(user_id) |