From d8aa3e10398d0d23eefdbda899475ca32ec3abf6 Mon Sep 17 00:00:00 2001 From: Simo Sorce Date: Thu, 7 May 2015 12:33:40 -0400 Subject: pylint 1.4.3 version fixes Pylint 1.4.3 completely stopped recognizing the star-args condition. In order to avoid pylint error with > 1.4.3 stop caring for star-args and add cmdline option to ignore those errors completly so older pylint versions are happy too. Also fix type() vs isinstance() checks, isinstance is generally a more correct approach to check for calsses. In some 'admin' files the type() -> isinstance() fix required to invert the order in which ComplexList and MappingList are checked as the latter is a subclass of ComplexList, so it needs to be checked first otherwise the check for isinstance(option, ComplexList) matches for both and the code stops funciotning properly. Signed-off-by: Simo Sorce --- ipsilon/login/authldap.py | 1 - 1 file changed, 1 deletion(-) (limited to 'ipsilon/login/authldap.py') diff --git a/ipsilon/login/authldap.py b/ipsilon/login/authldap.py index 595d6be..2882897 100644 --- a/ipsilon/login/authldap.py +++ b/ipsilon/login/authldap.py @@ -86,7 +86,6 @@ class LDAP(LoginFormBase, Log): error_username=not username ) self.lm.set_auth_error() - # pylint: disable=star-args return self._template('login/form.html', **context) -- cgit